Closed Bug 2053549 Opened 2 months ago Closed 29 days ago

Remove unused preference browser.tabs.remote.enforceRemoteTypeRestrictions

Categories

(Core :: DOM: Content Processes, task)

task

Tracking

()

RESOLVED FIXED
157 Branch
Tracking Status
firefox157 --- fixed

People

(Reporter: Sylvestre, Assigned: blessedonekobo, Mentored)

References

(Blocks 1 open bug)

Details

(Keywords: good-first-bug, Whiteboard: [lang=js])

Attachments

(1 file)

browser.tabs.remote.enforceRemoteTypeRestrictions (defined in modules/libpref/init/all.js, overridden in browser/app/profile/firefox.js) has no remaining reader.

Found by a static analysis of preference usage across mozilla-central: extract every defined pref, then scan the whole tree for each pref's name, its generated StaticPrefs::<id>() / Rust accessor identifier, set_spidermonkey_pref plumbing, and dynamic name-assembly patterns (macro ## paste, adjacent string literals, prefix + leaf concatenation, GetChildList enumeration). Static analysis cannot see access from add-ons or other external consumers, so please confirm before landing

Turning this into a good first bug to help a newcomer learn the workflow.

Link to the code:
https://searchfox.org/mozilla-central/source/modules/libpref/init/all.js#1909
https://searchfox.org/mozilla-central/source/browser/app/profile/firefox.js#1113

To verify the fix:

  • Confirm the pref has no remaining users by searching for browser.tabs.remote.enforceRemoteTypeRestrictions on https://searchfox.org (only the definition should match).
  • Build the tree to make sure nothing breaks:
    ./mach build

Tutorial to contribute:
https://firefox-source-docs.mozilla.org/contributing/contribution_quickref.html
https://firefox-source-docs.mozilla.org/contributing/stack_quickref.html

Please don't ask for the bug to be assigned. It will be automatically assigned to the first patch.

Mentor: sledru
Keywords: good-first-bug
Whiteboard: [lang=js]
Assignee: nobody → blessedonekobo
Status: NEW → ASSIGNED
Pushed by opettay@mozilla.com: https://github.com/mozilla-firefox/firefox/commit/7fc21e2aa965 https://hg.mozilla.org/integration/autoland/rev/16ce12687fd8 Remove unused browser.tabs.remote.enforceRemoteTypeRestrictions preference. r=dom-core-reviewers,smaug
Status: ASSIGNED → RESOLVED
Closed: 29 days ago
Resolution: --- → FIXED
Target Milestone: --- → 157 Branch
QA Whiteboard: [qa-triage-done-c158/b157]
You need to log in before you can comment on or make changes to this bug.