Closed Bug 2068111 Opened 29 days ago Closed 28 days ago

Fix ruff UP031 and PLW2901 warnings in python/mozbuild/mozbuild/action

Categories

(Firefox Build System :: Mach Core, enhancement)

Product:
Firefox Build System
Component:
Mach Core
Version:
Firefox 154
Type:
enhancement

Tracking

(firefox157 fixed)

Status:
RESOLVED FIXED
Milestone:
157 Branch
Tracking Flags:
Tracking Status
firefox157 --- fixed

People

(Reporter: sorb.hanzala, Assigned: sorb.hanzala, NeedInfo)

Details

Attachments

(2 files)

Bug 2068111 - Fix ruff UP031 and PLW2901 warnings in python/mozbuild/mozbuild/action r?#firefox-build-system-reviewers
48 bytes, text/x-phabricator-request
Details | Review
[mozilla-firefox/firefox] Bug 2068111 - Fix ruff UP031 and PLW2901 warnings in python/mozbuild/… (#353)
51 bytes, text/x-github-pull-request
Details | Review

User Agent: Mozilla/5.0 (X11; Ubuntu; Linux x86_64; rv:154.0) Gecko/20100101 Firefox/154.0

Steps to reproduce:

Fix UP031 and PLW2901 ruff warnings in python/mozbuild/mozbuild/action.

These warnings complain about the use of older percent-style string formatting which should be replaced with f-strings, and loop variables being overwritten by assignment targets.

To verify the fix:
./mach lint -W soft -l ruff python/mozbuild/mozbuild/action/

Replace percent-style string formatting with f-strings for modern Python style and fix loop variable overwriting warnings in python/mozbuild/mozbuild/action/.

Assignee: nobody → sorb.hanzala
Status: UNCONFIRMED → ASSIGNED
Ever confirmed: true

The Bugbug bot thinks this bug should belong to the 'Firefox Build System::Mach Core' component, and is moving the bug to that component. Please correct in case you think the bot is wrong.

Component: General → Mach Core
Pushed by sguelton@mozilla.com: https://github.com/mozilla-firefox/firefox/commit/1360793aad4e https://hg.mozilla.org/integration/autoland/rev/5d1fb4621dbd Fix ruff UP031 and PLW2901 warnings in python/mozbuild/mozbuild/action r=firefox-build-system-reviewers,sergesanspaille
Pushed by smolnar@mozilla.com: https://github.com/mozilla-firefox/firefox/commit/c017707b1cf3 https://hg.mozilla.org/integration/autoland/rev/17edf99ca40a Revert "Bug 2068111 - Fix ruff UP031 and PLW2901 warnings in python/mozbuild/mozbuild/action r=firefox-build-system-reviewers,sergesanspaille" for causing build bustages at libmozsqlite3.so.symbols.
Pushed by ahochheiden@mozilla.com: https://github.com/mozilla-firefox/firefox/commit/1a35a3803840 https://hg.mozilla.org/integration/autoland/rev/eec0e3d050a5 Fix ruff UP031 and PLW2901 warnings in python/mozbuild/mozbuild/action r=firefox-build-system-reviewers,sergesanspaille,ahochheiden

https://hg.mozilla.org/mozilla-central/rev/eec0e3d050a5

Status: ASSIGNED → RESOLVED
Closed: 28 days ago
status-firefox157: --- → fixed
Resolution: --- → FIXED
Target Milestone: --- → 157 Branch
You need to log in before you can comment on or make changes to this bug.