refactor: shorten and improve error messages to follow Go commandments

Author: alexastrum

src/skl/add.go

@@ -169,7 +169,7 @@ func AddSkill(src string, opts AddOptions, cwd string) error {
 		var err error
 		cwd, err = os.Getwd()
 		if err != nil {
-			return fmt.Errorf("failed to get current working directory: %w", err)
+			return fmt.Errorf("get working directory: %w", err)
 		}
 	}
 
@@ -240,10 +240,10 @@ func AddSkill(src string, opts AddOptions, cwd string) error {
 		for _, agentType := range targetAgents {
 			res, err := installSkillForAgent(skillName, dir, agentType, opts, cwd)
 			if err != nil {
-				return fmt.Errorf("failed to install skill for agent %s: %w", agentType, err)
+				return fmt.Errorf("install skill for agent %s: %w", agentType, err)
 			}
 			if !res.Success {
-				return fmt.Errorf("failed to install skill %q for agent %s: %s", skillName, agentType, res.Error)
+				return fmt.Errorf("install skill %q for agent %s: %s", skillName, agentType, res.Error)
 			}
 			if opts.Verbose {
 				status := "Installed"
@@ -427,7 +427,7 @@ func downloadRemote(repoURL string, ref string, opts AddOptions) (string, error)
 	resp, err := http.Get(zipURL)
 	if err != nil {
 		_ = os.RemoveAll(tmpDir)
-		return "", fmt.Errorf("failed to fetch from remote URL: %w", err)
+		return "", fmt.Errorf("fetch remote: %w", err)
 	}
 	defer resp.Body.Close()
 
@@ -453,7 +453,7 @@ func downloadRemote(repoURL string, ref string, opts AddOptions) (string, error)
 
 	if err := extractZip(resp.Body, tmpDir, verbose); err != nil {
 		_ = os.RemoveAll(tmpDir)
-		return "", fmt.Errorf("failed to extract downloaded zip: %w", err)
+		return "", fmt.Errorf("extract zip: %w", err)
 	}
 
 	return tmpDir, nil

src/skl/experimental_install.go

@@ -11,13 +11,13 @@ func RestoreFromLock(args []string, cwd string) error {
 		var err error
 		cwd, err = os.Getwd()
 		if err != nil {
-			return fmt.Errorf("failed to get working directory: %w", err)
+			return fmt.Errorf("get working directory: %w", err)
 		}
 	}
 
 	lock, err := ReadLocalLock(cwd)
 	if err != nil {
-		return fmt.Errorf("failed to read local lock file: %w", err)
+		return fmt.Errorf("read lock: %w", err)
 	}
 
 	if len(lock.Skills) == 0 {

src/skl/experimental_sync.go

@@ -100,7 +100,7 @@ func SyncSkills(args []string, opts SyncOptions, cwd string) error {
 		var err error
 		cwd, err = os.Getwd()
 		if err != nil {
-			return fmt.Errorf("failed to get working directory: %w", err)
+			return fmt.Errorf("get working directory: %w", err)
 		}
 	}
 
@@ -109,7 +109,7 @@ func SyncSkills(args []string, opts SyncOptions, cwd string) error {
 	}
 	discovered, err := DiscoverNodeModuleSkills(cwd)
 	if err != nil {
-		return fmt.Errorf("failed to discover node_modules skills: %w", err)
+		return fmt.Errorf("discover node_modules skills: %w", err)
 	}
 
 	if len(discovered) == 0 {
@@ -121,7 +121,7 @@ func SyncSkills(args []string, opts SyncOptions, cwd string) error {
 
 	lock, err := ReadLocalLock(cwd)
 	if err != nil {
-		return fmt.Errorf("failed to read local lock: %w", err)
+		return fmt.Errorf("read lock: %w", err)
 	}
 
 	canonicalBase := GetCanonicalSkillsDir(false, cwd)

src/skl/init.go

@@ -19,7 +19,7 @@ func InitSkill(opts InitOptions) (string, error) {
 		var err error
 		cwd, err = os.Getwd()
 		if err != nil {
-			return "", fmt.Errorf("failed to get current working directory: %w", err)
+			return "", fmt.Errorf("get working directory: %w", err)
 		}
 	}
 
@@ -48,7 +48,7 @@ func InitSkill(opts InitOptions) (string, error) {
 	// Create directory if name was provided
 	if hasName {
 		if err := os.MkdirAll(skillDir, 0755); err != nil {
-			return "", fmt.Errorf("failed to create skill directory: %w", err)
+			return "", fmt.Errorf("create skill directory: %w", err)
 		}
 	}
 
@@ -73,7 +73,7 @@ Describe when this skill should be used.
 `, skillName, skillName)
 
 	if err := os.WriteFile(skillFile, []byte(skillContent), 0644); err != nil {
-		return "", fmt.Errorf("failed to write SKILL.md: %w", err)
+		return "", fmt.Errorf("write skill template: %w", err)
 	}
 
 	return skillFile, nil

src/skl/remove.go

@@ -75,7 +75,7 @@ func RemoveSkills(skillNames []string, opts RemoveOptions, cwd string) error {
 		var err error
 		cwd, err = os.Getwd()
 		if err != nil {
-			return fmt.Errorf("failed to get working directory: %w", err)
+			return fmt.Errorf("get working directory: %w", err)
 		}
 	}
 
@@ -101,7 +101,7 @@ func RemoveSkills(skillNames []string, opts RemoveOptions, cwd string) error {
 
 	home, err := os.UserHomeDir()
 	if err != nil {
-		return fmt.Errorf("failed to resolve user home: %w", err)
+		return fmt.Errorf("resolve user home: %w", err)
 	}
 
 	configHome := os.Getenv("XDG_CONFIG_HOME")

src/skl/update.go

@@ -55,12 +55,12 @@ func UpdateSkill(name string, srcDir string, opts UpdateOptions) error {
 	skillMd := filepath.Join(skillDir, "SKILL.md")
 	bytes, err := os.ReadFile(skillMd)
 	if err != nil {
-		return fmt.Errorf("failed to read installed SKILL.md: %w", err)
+		return fmt.Errorf("read installed skill: %w", err)
 	}
 
 	// Write the exact same bytes back to update modification time and ensure write access
 	if err := os.WriteFile(skillMd, bytes, 0644); err != nil {
-		return fmt.Errorf("failed to refresh SKILL.md: %w", err)
+		return fmt.Errorf("refresh skill: %w", err)
 	}
 
 	return nil