Synchronize the cursor returned by followJournal#31263
Merged
Merged
Conversation
Make sure that the cursor value returned by followJournal() is the last of the values returned by its goroutine's calls to drainJournal() by waiting for it, rather than returning a value that may be superceded by another if we're singalling the goroutine that it should exit by closing a pipe. Signed-off-by: Nalin Dahyabhai <nalin@redhat.com>
Contributor
|
LGTM |
Merged
This was referenced Feb 28, 2017
Closed
This was referenced Mar 7, 2017
This was referenced May 3, 2017
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
7 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Make sure that the cursor value returned by
followJournal()is the last of the values returned by its goroutine's calls todrainJournal()by waiting for the goroutine to explicitly send the intended value back to its caller. Previously, iffollowJournal()signalled the goroutine that its work was done by closing a pipe, depending on scheduling, it was possible forfollowJournal()to return a value which the goroutine would also pass todrainJournal(), which would free the value and allocate another one.Along with #31231, this may be part of the cause for #30433.