feat: add support to a few more specific StorageErrors for the Write API by stephaniewang526 · Pull Request #1563 · googleapis/java-bigquerystorage

stephaniewang526 · 2022-03-04T16:15:31Z

OFFSET_OUT_OF_RANGE
OFFSET_ALREADY_EXISTS
STREAM_NOT_FOUND

Towards b/220198094

OFFSET_OUT_OF_RANGE OFFSET_ALREADY_EXISTS STREAM_NOT_FOUND Towards b/220198094

yirutang

Add a e2e test for all these exceptions + to show the StatusRuntimeException still works?

stephaniewang526 · 2022-03-04T21:43:39Z

Converting this to draft as we realized that there are backend changes needed (https://b.corp.google.com/issues/220198094#comment7) before proceeding.

yirutang · 2022-03-30T19:23:22Z

The exception backend change is fully rolled out.

See https://github.com/googleapis/repo-automation-bots/blob/main/packages/owl-bot/README.md

yirutang · 2022-04-29T18:35:03Z

      return null;
    }
+    String streamName = error.getEntity();
+    String errorMessage =


Add a comment about this is to trim the entity sub message. Also narrow it further down by looking for "Entity: ".

"Entity:..." is present in the detailMessage of OFFSET_OUT_OF_RANGE error when it should not be there since we already provide streamName in the error. The full detailMessage I get looks like: "OUT_OF_RANGE: The offset is within stream, expected offset 1, received 0 Entity: projects/.../datasets/.../tables/testtable/streams/CiQ2NGY3OT...".

I created b/231499869 to track this.

So why do you need to trim the next message?

What does "next message" mean? I added a comment here to clarify further. Basically, I need to trim the message of whitespaces either way (with or without Entity) in order to get the "expected offset [0-9]+, received [0-9]+" portion to parse out the offset numbers.

yirutang · 2022-04-29T18:49:04Z

+    Long expectedOffet =
+        Long.parseLong(
+            errorMessage.substring(
+                errorMessage.lastIndexOf("offset") + 7, errorMessage.lastIndexOf(",")));


Have a stream match pattern for "expected offset $0, received $1". I am writing cl/445470232 to make sure the parsing will not break.

See https://github.com/googleapis/repo-automation-bots/blob/main/packages/owl-bot/README.md

🤖 I have created a release *beep* *boop* --- ## [2.13.0](v2.12.2...v2.13.0) (2022-05-05) ### Features * add support to a few more specific StorageErrors for the Write API ([#1563](#1563)) ([c26091e](c26091e)) * next release from main branch is 2.12.2 ([#1624](#1624)) ([b2aa2a4](b2aa2a4)) ### Bug Fixes * A stuck when the client fail to get DoneCallback ([#1637](#1637)) ([3baa84e](3baa84e)) * Fix a possible NULL PTR after introduced timeout on waitForDone ([#1638](#1638)) ([e1c6ded](e1c6ded)) ### Dependencies * update dependency com.google.cloud:google-cloud-bigquery to v2.10.10 ([#1623](#1623)) ([54b74b8](54b74b8)) * update dependency org.apache.avro:avro to v1.11.0 ([#1632](#1632)) ([b47eea0](b47eea0)) ### Documentation * **samples:** update WriteComittedStream sample code to match best practices ([#1628](#1628)) ([5d4c7e1](5d4c7e1)) * **sample:** update WriteToDefaultStream sample to match best practices ([#1631](#1631)) ([73ddd7b](73ddd7b)) --- This PR was generated with [Release Please](https://github.com/googleapis/release-please). See [documentation](https://github.com/googleapis/release-please#release-please).

feat: add support to a few more specific StorageErrors for the Write API

be4a20b

OFFSET_OUT_OF_RANGE OFFSET_ALREADY_EXISTS STREAM_NOT_FOUND Towards b/220198094

stephaniewang526 requested review from a team and tswast March 4, 2022 16:15

product-auto-label Bot added the api: bigquerystorage Issues related to the googleapis/java-bigquerystorage API. label Mar 4, 2022

stephaniewang526 requested a review from yirutang March 4, 2022 16:15

stephaniewang526 added the owlbot:run Add this label to trigger the Owlbot post processor. label Mar 4, 2022

gcf-owl-bot Bot removed the owlbot:run Add this label to trigger the Owlbot post processor. label Mar 4, 2022

yirutang reviewed Mar 4, 2022

View reviewed changes

stephaniewang526 added 2 commits March 4, 2022 15:57

add integration test for streamNotFound

5920c12

add integration test for streamNotFound

d4c2e34

stephaniewang526 marked this pull request as draft March 4, 2022 20:59

yirutang reviewed Mar 25, 2022

View reviewed changes

Comment thread google-cloud-bigquerystorage/src/main/java/com/google/cloud/bigquery/storage/v1/Exceptions.java

stephaniewang526 added 2 commits April 1, 2022 11:45

Merge branch 'main' into more-storageError

532413c

add more changes since backend changes have rolled out

3627005

product-auto-label Bot added the size: m Pull request size is medium. label Apr 25, 2022

stephaniewang526 marked this pull request as ready for review April 25, 2022 19:09

stephaniewang526 requested a review from yirutang April 25, 2022 19:10

update clirr-ignored-differences.xml

f8908f0

stephaniewang526 requested a review from a team April 25, 2022 20:30

stephaniewang526 added 2 commits April 25, 2022 16:32

update IT

d1929d1

nit

c797573

stephaniewang526 added the owlbot:run Add this label to trigger the Owlbot post processor. label Apr 25, 2022

gcf-owl-bot Bot removed the owlbot:run Add this label to trigger the Owlbot post processor. label Apr 25, 2022

🦉 Updates from OwlBot post-processor

531ead3

See https://github.com/googleapis/repo-automation-bots/blob/main/packages/owl-bot/README.md

yirutang reviewed Apr 29, 2022

View reviewed changes

add error message match pattern

f6797ac

stephaniewang526 requested a review from yirutang May 5, 2022 02:05

stephaniewang526 added the owlbot:run Add this label to trigger the Owlbot post processor. label May 5, 2022

gcf-owl-bot Bot removed the owlbot:run Add this label to trigger the Owlbot post processor. label May 5, 2022

🦉 Updates from OwlBot post-processor

f125f78

See https://github.com/googleapis/repo-automation-bots/blob/main/packages/owl-bot/README.md

stephaniewang526 added the owlbot:run Add this label to trigger the Owlbot post processor. label May 5, 2022

gcf-owl-bot Bot removed the owlbot:run Add this label to trigger the Owlbot post processor. label May 5, 2022

yirutang approved these changes May 5, 2022

View reviewed changes

stephaniewang526 merged commit c26091e into googleapis:main May 5, 2022

release-please Bot mentioned this pull request May 5, 2022

chore(main): release 2.13.0 #1626

Merged

Navigation Menu

feat: add support to a few more specific StorageErrors for the Write API - #1563

feat: add support to a few more specific StorageErrors for the Write API#1563
stephaniewang526 merged 11 commits into
googleapis:mainfrom
stephaniewang526:more-storageError

stephaniewang526 commented Mar 4, 2022

yirutang left a comment

stephaniewang526 commented Mar 4, 2022

Uh oh!

yirutang commented Mar 30, 2022

yirutang Apr 29, 2022

stephaniewang526 May 5, 2022 •

edited

Loading

yirutang May 5, 2022

stephaniewang526 May 5, 2022 •

edited

Loading

yirutang Apr 29, 2022 •

edited

Loading

stephaniewang526 May 5, 2022

Labels

2 participants

Conversation

stephaniewang526 commented Mar 4, 2022

yirutang left a comment

Choose a reason for hiding this comment

stephaniewang526 commented Mar 4, 2022

Uh oh!

yirutang commented Mar 30, 2022

yirutang Apr 29, 2022

Choose a reason for hiding this comment

stephaniewang526 May 5, 2022 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

yirutang May 5, 2022

Choose a reason for hiding this comment

stephaniewang526 May 5, 2022 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

yirutang Apr 29, 2022 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

stephaniewang526 May 5, 2022

Choose a reason for hiding this comment

Labels

2 participants

stephaniewang526 May 5, 2022 •

edited

Loading

stephaniewang526 May 5, 2022 •

edited

Loading

yirutang Apr 29, 2022 •

edited

Loading