Skip to content
This repository was archived by the owner on Mar 2, 2026. It is now read-only.

fix: expose Count, FieldFilter, Or, and And to firestore module#706

Merged
Mariatta merged 2 commits into
mainfrom
fix-issue-704
Apr 26, 2023
Merged

fix: expose Count, FieldFilter, Or, and And to firestore module#706
Mariatta merged 2 commits into
mainfrom
fix-issue-704

Conversation

@Mariatta

@Mariatta Mariatta commented Apr 25, 2023

Copy link
Copy Markdown
Contributor

Expose the Count, FieldFilter, Or, and And to the firestore module from the firestore_v1.

Thank you for opening a Pull Request! Before submitting your PR, there are a few things you can do to make sure it goes smoothly:

  • Make sure to open an issue as a bug/issue before writing your code! That way we can discuss the change, evaluate designs, and agree on the general idea
  • Ensure the tests and linter pass
  • Code coverage does not decrease (if any source code was changed)
  • Appropriate docs were updated (if necessary)

Fixes #704 🦕
@Mariatta
fix: expose Count, FieldFilter, Or, and And to firestore module
93daf3d 
Expose the `Count`, `FieldFilter`, `Or`, and `And` to the `firestore` module from the `firestore_v1`.
@Mariatta Mariatta requested review from a team April 25, 2023 18:25
@product-auto-label product-auto-label Bot added size: s Pull request size is small. api: firestore Issues related to the googleapis/python-firestore API. labels Apr 25, 2023
@Mariatta Mariatta added the kokoro:force-run Add this label to force Kokoro to re-run the tests. label Apr 25, 2023
@yoshi-kokoro yoshi-kokoro removed the kokoro:force-run Add this label to force Kokoro to re-run the tests. label Apr 25, 2023
@Mariatta Mariatta added the kokoro:force-run Add this label to force Kokoro to re-run the tests. label Apr 26, 2023
@yoshi-kokoro yoshi-kokoro removed the kokoro:force-run Add this label to force Kokoro to re-run the tests. label Apr 26, 2023
@Mariatta Mariatta merged commit 8eb2c88 into main Apr 26, 2023
@Mariatta Mariatta deleted the fix-issue-704 branch April 26, 2023 16:46
@release-please release-please Bot mentioned this pull request Apr 26, 2023
Merged
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

api: firestore Issues related to the googleapis/python-firestore API. size: s Pull request size is small.

3 participants

@Mariatta @telpirion @yoshi-kokoro