Skip to content
This repository was archived by the owner on Mar 31, 2026. It is now read-only.

feat: add turbo replication support and samples - #622

Merged
unforced merged 27 commits into
googleapis:mainfrom
unforced:rpo-changes
Jan 18, 2022
Merged

feat: add turbo replication support and samples#622
unforced merged 27 commits into
googleapis:mainfrom
unforced:rpo-changes

Conversation

@unforced

@unforced unforced commented Oct 13, 2021 •
edited
Loading

Copy link
Copy Markdown
Contributor

Fixes #605 and #606
@unforced
unforced requested review from a team and ddelgrosso1 October 13, 2021 19:33
@product-auto-label product-auto-label Bot added the api: storage Issues related to the googleapis/python-storage API. label Oct 13, 2021
@google-cla google-cla Bot added the cla: yes This human has signed the Contributor License Agreement. label Oct 13, 2021
tseaver
tseaver reviewed Oct 13, 2021
View reviewed changes
Comment thread google/cloud/storage/client.py Outdated
@unforced unforced added the kokoro:force-run Add this label to force Kokoro to re-run the tests. label Oct 13, 2021
@yoshi-kokoro yoshi-kokoro removed the kokoro:force-run Add this label to force Kokoro to re-run the tests. label Oct 13, 2021
cojenco
cojenco reviewed Oct 14, 2021
View reviewed changes
Comment thread google/cloud/storage/bucket.py
cojenco
cojenco reviewed Oct 14, 2021
View reviewed changes
Comment thread tests/unit/test_bucket.py
@snippet-bot

snippet-bot Bot commented Oct 19, 2021 •
edited
Loading

Copy link
Copy Markdown

Here is the summary of changes.

You are about to add 4 region tags.

This comment is generated by snippet-bot.
If you find problems with this result, please file an issue at:
https://github.com/googleapis/repo-automation-bots/issues.
To update this comment, add snippet-bot:force-run label or use the checkbox below:

  • Refresh this comment
@unforced unforced changed the title feat: add turbo replication support Oct 19, 2021
@product-auto-label product-auto-label Bot added the samples Issues that are directly related to samples. label Oct 20, 2021
cojenco
cojenco reviewed Oct 20, 2021
View reviewed changes
Comment thread samples/snippets/rpo_test.py Outdated
cojenco
cojenco reviewed Oct 20, 2021
View reviewed changes
Comment thread samples/snippets/storage_get_rpo.py Outdated
cojenco
cojenco reviewed Oct 20, 2021
View reviewed changes
Comment thread samples/snippets/storage_set_rpo_async_turbo.py Outdated
cojenco
cojenco approved these changes Oct 20, 2021
View reviewed changes

@cojenco cojenco left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for working on this! A few nits, otherwise LGTM
@cojenco cojenco added the do not merge Indicates a pull request not ready for merge, due to either quality or timing. label Nov 8, 2021
@ddelgrosso1

ddelgrosso1 commented Jan 10, 2022

Copy link
Copy Markdown
Contributor

This can be merged / released now.
@unforced unforced removed the do not merge Indicates a pull request not ready for merge, due to either quality or timing. label Jan 12, 2022
@unforced
unforced requested a review from a team as a code owner January 12, 2022 15:54
@unforced
unforced requested a review from nicain January 12, 2022 15:54
@unforced unforced added the kokoro:force-run Add this label to force Kokoro to re-run the tests. label Jan 12, 2022
@yoshi-kokoro yoshi-kokoro removed the kokoro:force-run Add this label to force Kokoro to re-run the tests. label Jan 12, 2022
@dandhlee dandhlee added cla: yes This human has signed the Contributor License Agreement. and removed cla: yes This human has signed the Contributor License Agreement. labels Jan 12, 2022
dandhlee
dandhlee reviewed Jan 13, 2022
View reviewed changes
Comment thread samples/snippets/rpo_test.py
@unforced unforced mentioned this pull request Jan 18, 2022
Closed
@unforced
unforced merged commit 4dafc81 into googleapis:main Jan 18, 2022
@release-please release-please Bot mentioned this pull request Jan 18, 2022
Merged
@cojenco cojenco mentioned this pull request Feb 9, 2022
Closed
@release-please release-please Bot mentioned this pull request Aug 10, 2022
Merged
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

api: storage Issues related to the googleapis/python-storage API. cla: yes This human has signed the Contributor License Agreement. samples Issues that are directly related to samples.

6 participants

@unforced @ddelgrosso1 @tseaver @cojenco @dandhlee @yoshi-kokoro