This repository was archived by the owner on Mar 31, 2026. It is now read-only.
fix: remove client side validations - #868
Merged
Merged
Conversation
product-auto-label
Bot
added
size: s
cojenco
added
the
kokoro:force-run
yoshi-kokoro
removed
the
kokoro:force-run
cojenco
added
the
kokoro:force-run
yoshi-kokoro
removed
the
kokoro:force-run
product-auto-label
Bot
added
size: m
cojenco
marked this pull request as ready for review
September 29, 2022 21:36
andrewsg
approved these changes
Oct 5, 2022
andrewsg
left a comment
andrewsg
left a comment
Contributor
There was a problem hiding this comment.
Thanks for adding tests as discussed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Remove client-side validations and fall back to API errors per internal review doc
Fixes #879
Fixes #880