Skip to content

Improve downloading log message#1920

Merged
angelapwen merged 1 commit into
github:mainfrom
hoshinotsuyoshi:hoshinotsuyoshi/improve-log-url-in-setup-codeql
Oct 5, 2023
Merged

Improve downloading log message#1920
angelapwen merged 1 commit into
github:mainfrom
hoshinotsuyoshi:hoshinotsuyoshi/improve-log-url-in-setup-codeql

Conversation

@hoshinotsuyoshi

@hoshinotsuyoshi hoshinotsuyoshi commented Oct 4, 2023

Copy link
Copy Markdown
Contributor

Regarding GitHub Actions log output, the dot was recognized as part of the URL.

dot

404error

Merge / deployment checklist

  • Confirm this change is backwards compatible with existing workflows.
  • Confirm the readme has been updated if necessary.
  • Confirm the changelog has been updated if necessary.
@hoshinotsuyoshi hoshinotsuyoshi marked this pull request as ready for review October 4, 2023 18:43
@hoshinotsuyoshi hoshinotsuyoshi requested a review from a team as a code owner October 4, 2023 18:43

@angelapwen angelapwen left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for the contribution @hoshinotsuyoshi ✨ You will need to run npm run build in order to regenerate the relevant transpilation files.

Regarding GitHub Actions log output, the dot was recognized as part of the URL.
@hoshinotsuyoshi hoshinotsuyoshi force-pushed the hoshinotsuyoshi/improve-log-url-in-setup-codeql branch from d9c08be to 6fe4546 Compare October 5, 2023 07:12
@hoshinotsuyoshi

Copy link
Copy Markdown
Contributor Author

@angelapwen Thank you! force-pushed 6fe4546 .

@angelapwen angelapwen left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good! I will turn auto-merge on for when the PR checks pass 🥳

@angelapwen angelapwen enabled auto-merge (squash) October 5, 2023 19:52
@aeisenberg

aeisenberg commented Oct 5, 2023

Copy link
Copy Markdown
Contributor

The failing resolve-environment test recently had some changes. I wonder if something is wrong with the test.

@angelapwen

Copy link
Copy Markdown
Contributor

I think it should be unrelated as the failure is mv: cannot move 'node_modules' to '../action/node_modules': Permission denied in the prepare step. I'll re-run.

@angelapwen angelapwen merged commit 3f7850a into github:main Oct 5, 2023
@github-actions github-actions Bot mentioned this pull request Oct 6, 2023
6 tasks
@hoshinotsuyoshi hoshinotsuyoshi deleted the hoshinotsuyoshi/improve-log-url-in-setup-codeql branch October 10, 2023 01:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

3 participants