Join GitHub today
GitHub is home to over 31 million developers working together to host and review code, manage projects, and build software together.
Sign upCreate CONTRIBUTING.md #6386
Conversation
dnfclas
added
the
cla-already-signed
label
Jul 21, 2016
This comment has been minimized.
This comment has been minimized.
|
LGTM. In the future, please create a branch in your own fork instead of on the main repo when sending a PR, so that everyone who's pulling from the repo doesn't get your branch. |
This comment has been minimized.
This comment has been minimized.
|
I've opened an issue for the Windows test failure: #6397 Feel free to ignore it; I'm going to assume this change didn't break threading. |
This comment has been minimized.
This comment has been minimized.
|
Fair enough on the additional branch. I have my own fork. I'll use it. |
richlander
merged commit 519d7d6
into
master
Jul 22, 2016
9 of 10 checks passed
Windows_NT x64 Release Priority 1 Build and Test
Build finished.
Details
CentOS7.1 x64 Debug Build and Test
Build finished.
Details
FreeBSD x64 Checked Build
Build finished.
Details
Linux ARM Emulator Cross Debug Build
Build finished.
Details
Linux ARM Emulator Cross Release Build
Build finished.
Details
OSX x64 Checked Build and Test
Build finished.
Details
Ubuntu x64 Checked Build and Test
Build finished.
Details
Windows_NT x64 Debug Build and Test
Build finished.
Details
Windows_NT x86 legacy_backend Checked Build and Test
Build finished.
Details
Windows_NT x86 ryujit Checked Build and Test
Build finished.
Details
richlander
deleted the
richlander-patch-1
branch
Jul 22, 2016
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
richlander commentedJul 21, 2016
This file exists in corefx and is an obvious file to look for. Making the two repos the same.