Join GitHub today
GitHub is home to over 50 million developers working together to host and review code, manage projects, and build software together.
Sign upGitHub is where the world builds software
Millions of developers and companies build, ship, and maintain their software on GitHub — the largest and most advanced development platform in the world.
Fix the instantiation of new objects #79
Merged
Conversation
| def __init__(self, prop_dict={}): | ||
| self._prop_dict = prop_dict | ||
| def __init__(self, prop_dict=None): | ||
| self._prop_dict = prop_dict if prop_dict else {} |
cdmayer
Nov 7, 2016
Contributor
self._prop_dict = prop_dict if prop_dict else {}
I would go with prop_dict if prop_dict is not None else {} because it reads a bit better
| @@ -30,7 +30,7 @@ | |||
| class AsyncOperationStatus(OneDriveObjectBase): | |||
|
|
|||
| def __init__(self, prop_dict=None): | |||
| self._prop_dict = prop_dict if prop_dict else {} | |||
| self._prop_dict = prop_dict if prop_dict not None else {} | |||
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Fixes bug #78