Skip to content
This repository was archived by the owner on Mar 2, 2026. It is now read-only.

feat: asyncio microgen transaction#123

Merged
rafilong merged 21 commits into
googleapis:v2-stagingfrom
rafilong:asyncio-microgen-transaction
Jul 28, 2020
Merged

feat: asyncio microgen transaction#123
rafilong merged 21 commits into
googleapis:v2-stagingfrom
rafilong:asyncio-microgen-transaction

Conversation

@rafilong

@rafilong rafilong commented Jul 22, 2020

Copy link
Copy Markdown
Contributor

Resolves #78
rafilong added 16 commits July 21, 2020 18:24
@rafilong rafilong added this to the AsyncIO Client milestone Jul 22, 2020
@google-cla google-cla Bot added the cla: yes This human has signed the Contributor License Agreement. label Jul 22, 2020
tritone
tritone reviewed Jul 23, 2020
View reviewed changes

@tritone tritone left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Generally looks good, one question about testing.
Comment thread tests/unit/v1/test_async_transaction.py
@rafilong rafilong mentioned this pull request Jul 28, 2020
Merged
crwilcox
crwilcox reviewed Jul 28, 2020
View reviewed changes
Comment thread google/cloud/firestore_v1/async_transaction.py
Comment thread tests/unit/v1/test_async_transaction.py
@rafilong rafilong mentioned this pull request Jul 28, 2020
Closed
@rafilong rafilong merged commit 35185a8 into googleapis:v2-staging Jul 28, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

cla: yes This human has signed the Contributor License Agreement.

4 participants

@rafilong @crwilcox @BenWhitehead @tritone