Skip to content
This repository was archived by the owner on Mar 2, 2026. It is now read-only.

fix: limit data transferred as part of list_documents as we don't require field data#280

Merged
crwilcox merged 3 commits into
googleapis:masterfrom
crwilcox:limit-data-xfer-list-documents
Dec 16, 2020
Merged

fix: limit data transferred as part of list_documents as we don't require field data#280
crwilcox merged 3 commits into
googleapis:masterfrom
crwilcox:limit-data-xfer-list-documents

Conversation

@crwilcox

@crwilcox crwilcox commented Dec 16, 2020 •
edited
Loading

Copy link
Copy Markdown
Contributor

As we don't use any of the field data as part of list_documents, we can exclude it from the request/wire :)

Fixes #5 🦕
@crwilcox crwilcox requested a review from a team December 16, 2020 17:54
@google-cla google-cla Bot added the cla: yes This human has signed the Contributor License Agreement. label Dec 16, 2020
@product-auto-label product-auto-label Bot added the api: firestore Issues related to the googleapis/python-firestore API. label Dec 16, 2020
schmidt-sebastian
schmidt-sebastian approved these changes Dec 16, 2020
View reviewed changes

@schmidt-sebastian schmidt-sebastian left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This matches https://github.com/googleapis/nodejs-firestore/blob/3cd29d22073cff8d0ca072057c63dfe0a2144841/dev/src/reference.ts#L2436
@crwilcox crwilcox merged commit 0386bc4 into googleapis:master Dec 16, 2020
@crwilcox crwilcox deleted the limit-data-xfer-list-documents branch December 16, 2020 19:45
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

api: firestore Issues related to the googleapis/python-firestore API. cla: yes This human has signed the Contributor License Agreement.

3 participants

@crwilcox @BenWhitehead @schmidt-sebastian