Skip to content
This repository was archived by the owner on Mar 2, 2026. It is now read-only.

fix: reseed for each auto id on 3.6 to avoid collisions#388

Merged
crwilcox merged 6 commits into
googleapis:masterfrom
crwilcox:fix-seed-collisions
Jul 7, 2021
Merged

fix: reseed for each auto id on 3.6 to avoid collisions#388
crwilcox merged 6 commits into
googleapis:masterfrom
crwilcox:fix-seed-collisions

Conversation

@crwilcox

@crwilcox crwilcox commented Jul 2, 2021

Copy link
Copy Markdown
Contributor

Fixes #346 🦕

Upon further investigation, this is only an issue for python 3.6. In 2022, when 3.6 is no longer supported, this patch could be removed.

@crwilcox crwilcox requested review from a team July 2, 2021 23:02
@google-cla google-cla Bot added the cla: yes This human has signed the Contributor License Agreement. label Jul 2, 2021
@product-auto-label product-auto-label Bot added the api: firestore Issues related to the googleapis/python-firestore API. label Jul 2, 2021
@crwilcox crwilcox force-pushed the fix-seed-collisions branch from 21008ef to 6524b10 Compare July 2, 2021 23:03
Comment thread google/cloud/firestore_v1/base_collection.py Outdated
@crwilcox crwilcox changed the title fix: reseed for each auto id using a threadsafe uuid Jul 6, 2021
@crwilcox crwilcox added the kokoro:force-run Add this label to force Kokoro to re-run the tests. label Jul 7, 2021
@yoshi-kokoro yoshi-kokoro removed the kokoro:force-run Add this label to force Kokoro to re-run the tests. label Jul 7, 2021

@craiglabenz craiglabenz left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pseudorandom? More like SUDOrandom, amirite?

@crwilcox crwilcox merged commit 784e8ae into googleapis:master Jul 7, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

api: firestore Issues related to the googleapis/python-firestore API. cla: yes This human has signed the Contributor License Agreement.

4 participants