Skip to content

fix: Add ClientCache which forces new client creation after 75 uses#188

Merged
dpcollins-google merged 2 commits into
masterfrom
client_cache
Jul 16, 2021
Merged

fix: Add ClientCache which forces new client creation after 75 uses#188
dpcollins-google merged 2 commits into
masterfrom
client_cache

Conversation

@dpcollins-google

@dpcollins-google dpcollins-google commented Jul 15, 2021

Copy link
Copy Markdown
Contributor

This avoids the 100 stream per channel GRPC limit.

Thank you for opening a Pull Request! Before submitting your PR, there are a few things you can do to make sure it goes smoothly:

  • Make sure to open an issue as a bug/issue before writing your code! That way we can discuss the change, evaluate designs, and agree on the general idea
  • Ensure the tests and linter pass
  • Code coverage does not decrease (if any source code was changed)
  • Appropriate docs were updated (if necessary)

Fixes #<issue_number_goes_here> 🦕
@dpcollins-google
fix: Add ClientCache which forces new client creation after 75 uses
64d7994 
This avoids the 100 stream per channel GRPC limit.
@dpcollins-google dpcollins-google requested review from a team July 15, 2021 23:02
@google-cla google-cla Bot added the cla: yes This human has signed the Contributor License Agreement. label Jul 15, 2021
@product-auto-label product-auto-label Bot added the api: pubsublite Issues related to the googleapis/python-pubsublite API. label Jul 15, 2021
@dpcollins-google dpcollins-google merged commit 089789c into master Jul 16, 2021
@dpcollins-google dpcollins-google deleted the client_cache branch July 16, 2021 02:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

api: pubsublite Issues related to the googleapis/python-pubsublite API. cla: yes This human has signed the Contributor License Agreement.

2 participants

@dpcollins-google @manuelmenzella-google