Fix master ipv4 cidr psc#1154
Merged
Merged
Conversation
|
🤖 Hi @FIoannides, I've received your request, and I'm working on it now! You can track my progress in the logs for more details. |
FIoannides
requested review from
SikaGrr,
jamOne-,
scaliby and
stony-tark
as code owners
|
🤖 I'm sorry @FIoannides, but I was unable to process your request. Please see the logs for more details. |
scaliby
approved these changes
Mar 24, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
When using Private Service Connect (PSC) (introduced in #1124), we must not set the master IPv4 CIDR address, changing this to None.
The cluster-toolkit's gke-cluster Terraform module defines a default value for master_ipv4_cidr_block ("172.16.0.32/28"). When Private Service Connect (PSC) is used for a cluster, GKE requires that no master IPv4 CIDR block is provided. Because xpk currently doesn't override this value, the default is sent to the GKE API, causing the conflict.
Issue
Testing
https://github.com/AI-Hypercomputer/xpk/actions/runs/23490396828/job/68356833794