Fixes #29: Add a sims_per_round flag - #34
Merged
Merged
Conversation
Contributor
Author
|
Also resolves #19 (used |
Contributor
|
oh shoot, didn't realize this would get conflicts. Maybe let me resolve conflicts and just merge so it doesn't block further development |
Contributor
Author
|
oh sounds good, i just resolved! It wasn't too bad |
Contributor
Author
|
But yeah maybe we can merge, if the changes so far look ok? |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Adds a
sims_per_roundflag that is set as a parameter thegamesection of the a config file. The main change that this also causes is that the logs thatexecute_roundreturns anddetermine_winnerparses are nowlist[str]instead of juststr.Requesting review from you @klieret because I think with the repetition of games, I did end up removing some logging statements. Maybe we want to add some of these back?