Keep YAML document separators in generated CRD manifests - #46
Merged
Merged
Conversation
Without separators, helm show crds concatenates the chart's two CRD files into one invalid stream and kubectl apply silently applies only the first — the documented migration command half-applied exactly when it mattered (found by the rc.3 boundary recovery step). install.yaml assembly strips separators per-file itself and is unaffected; envtest and helm lint/template verified against the separated files.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The rc.3 boundary test's recovery step found the documented migration command half-broken:
helm show crds | kubectl applyapplied only ONE of the two CRDs. Root cause: the manifests post-processing stripped YAML document separators, sohelm show crds(which concatenatescrds/files) emitted two CRDs with zero separators — kubectl parsed one document. The per-probe readiness check then correctly kept the pod NotReady on the missing config informer, which is how this surfaced.Fix: generated manifests keep their
---separators (boilerplate header, then separator, then doc). Verified: chart lint/template clean,helm show crds-style concatenation now parses as two documents, install.yaml assembly unaffected (it strips per-file itself — 8 docs, 2 CRDs, ruby-validated), envtest loads the separated CRDs (dual-version test green).Boundary-session status: everything else passed on rc.3 — stall with zero-downtime continuity, recovery, UID preservation, dual-serving, storage assertion, boundary rollback. This is the last blocker; rc.4 verifies the fixed command end-to-end on GKE, then v1.3.0.