Skip to content

BigQuery test refinement #1712

Description

@nj1973

In data_sources/test_bigquery.py we set:

os.environ[consts.ENV_DIRECTORY_VAR] = f"gs://{TEST_BUCKET}/integration_tests/"

I imagine the intention was that this takes effect only for specific tests in this module but it ends up affecting all tests. We should look into refining this so the environment change is only in effect where intended.

This is not currently doing any harm so is low priority.

Activity

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

No one assigned

    Labels

    priority: p3Lowest priority. This can be something deprioritized or not time sensitive.type: testing

    Type

    Projects

    No projects

      Milestone

      No milestone

      Relationships

      None yet

      Development

      No branches or pull requests

      Issue actions