Skip to content

Connections add on SQL Server does not test the connection before adding it #1844

Description

@nj1973

Describe the bug
Connections add on SQL Server does not test the connection before adding it, e.g.:

$ data-validation connections add  -c sql_server_bad MSSQL --host=a.b.c.d --user=dvtuser --password=AAAAA --database=not-a-db
10/01/2026 10:29:46 AM-INFO: Success! Config output written to /home/me/.config/google-pso-data-validator/sql_server_bad.connection.json

What version of DVT are you using?
8.9.3

What type of connections are you using for source and target?
SQL Server

Expected behavior
Expect the connection to be validated. See PostgreSQL output below:

$ data-validation connections add  -c pg_bad Postgres --host=a.b.c.d --user=dvtuser --password=AAAAA --database=not-a-db
Traceback (most recent call last):
...
    raise exceptions.DataClientConnectionFailure(msg)
data_validation.exceptions.DataClientConnectionFailure: Connection Type "Postgres" could not connect: (psycopg2.OperationalError) could not translate host name "a.b.c.d" to address: Name or service not known

Activity

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

Labels

type: bugError or flaw in code with unintended results or allowing sub-optimal usage patterns.

Type

Projects

No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions