Skip to content

fix: update gcr.io/kpt-fn/ to ghcr.io/kptdev/krm-functions-catalog fo…#10020

Merged
Darien-Lin merged 4 commits into
GoogleContainerTools:mainfrom
menahyouyeah:kpt
Mar 19, 2026
Merged

fix: update gcr.io/kpt-fn/ to ghcr.io/kptdev/krm-functions-catalog fo…#10020
Darien-Lin merged 4 commits into
GoogleContainerTools:mainfrom
menahyouyeah:kpt

Conversation

@menahyouyeah

@menahyouyeah menahyouyeah commented Mar 19, 2026

Copy link
Copy Markdown
Contributor

Fixes: #10019

Description
The KRM function images were removed from ghcr.io/kpt-fn on March 13th. Updating them to use the new ghcr.io/kptdev/krm-functions-catalog

@menahyouyeah menahyouyeah requested a review from a team as a code owner March 19, 2026 15:15
@gemini-code-assist

Copy link
Copy Markdown
Contributor

Summary of Changes

Hello, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!

This pull request addresses a critical issue where KRM function images were moved to a new registry. By updating the image paths, it ensures the continued functionality of KRM transformers within Skaffold, preventing disruptions caused by broken image references.

Highlights

  • KRM Function Image Registry Update: Updated all KRM function image references from gcr.io/kpt-fn/ to ghcr.io/kptdev/krm-functions-catalog/ to reflect the new registry location.

🧠 New Feature in Public Preview: You can now enable Memory to help Gemini Code Assist learn from your team's feedback. This makes future code reviews more consistent and personalized to your project's style. Click here to enable Memory in your admin console.

Using Gemini Code Assist

The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.

Invoking Gemini

You can request assistance from Gemini at any point by creating a comment using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands on the current page.

Feature Command Description
Code Review /gemini review Performs a code review for the current pull request in its current state.
Pull Request Summary /gemini summary Provides a summary of the current pull request in its current state.
Comment @gemini-code-assist Responds in comments when explicitly tagged, both in pull request comments and review comments.
Help /gemini help Displays a list of available commands.

Customization

To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.

Limitations & Feedback

Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for GitHub and other Google products, sign up here.

Footnotes

  1. Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution.

Comment thread pkg/skaffold/render/transform/transform.go Outdated
Comment thread pkg/skaffold/render/transform/transform.go Outdated
Comment thread pkg/skaffold/render/transform/transform.go Outdated

@gemini-code-assist gemini-code-assist Bot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

The pull request successfully updates the image registry paths for KRM functions from gcr.io/kpt-fn/ to ghcr.io/kptdev/krm-functions-catalog/ in pkg/skaffold/render/transform/transform.go. This change directly addresses the issue of deprecated image locations, ensuring the application uses the correct function images. For future maintainability, consider refactoring the repeated image prefix into a package-level constant.

transformerAllowlist = map[string]kptfile.Function{
"set-namespace": {
Image: "gcr.io/kpt-fn/set-namespace:v0.4.1",
Image: "ghcr.io/kptdev/krm-functions-catalog/set-namespace:v0.4.1",

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

medium

The string "ghcr.io/kptdev/krm-functions-catalog/" is repeated across multiple Image fields within the transformerAllowlist map. To improve maintainability and reduce redundancy, consider defining this common prefix as a package-level constant. This would simplify future updates if the base registry path changes again, requiring only a single modification.

@menahyouyeah menahyouyeah added the kokoro:force-run forces a kokoro re-run on a PR label Mar 19, 2026
@Darien-Lin Darien-Lin enabled auto-merge (squash) March 19, 2026 18:09
@Darien-Lin Darien-Lin self-assigned this Mar 19, 2026
@Darien-Lin Darien-Lin merged commit c143747 into GoogleContainerTools:main Mar 19, 2026
11 of 12 checks passed
ruhi-chaddha pushed a commit to ruhi-chaddha/skaffold that referenced this pull request Mar 19, 2026
GoogleContainerTools#10020)

* fix: update gcr.io/kpt-fn/ to ghcr.io/kptdev/krm-functions-catalog for the kpt transformers

* fix some images, update unit test

* fix some images, update unit test

* integration test fixes
ruhi-chaddha added a commit that referenced this pull request Mar 19, 2026
fix: update gcr.io/kpt-fn/ to ghcr.io/kptdev/krm-functions-catalog fo… (#10020)

* fix: update gcr.io/kpt-fn/ to ghcr.io/kptdev/krm-functions-catalog for the kpt transformers

* fix some images, update unit test

* fix some images, update unit test

* integration test fixes

Co-authored-by: menahyouyeah <minnah@google.com>
ChrisGe4 pushed a commit to ChrisGe4/skaffold that referenced this pull request Apr 7, 2026
GoogleContainerTools#10020)

* fix: update gcr.io/kpt-fn/ to ghcr.io/kptdev/krm-functions-catalog for the kpt transformers

* fix some images, update unit test

* fix some images, update unit test

* integration test fixes

(cherry picked from commit c143747)
@menahyouyeah menahyouyeah deleted the kpt branch April 8, 2026 15:16
orospakr pushed a commit to orospakr/skaffold-spawnexec that referenced this pull request May 14, 2026
GoogleContainerTools#10020)

* fix: update gcr.io/kpt-fn/ to ghcr.io/kptdev/krm-functions-catalog for the kpt transformers

* fix some images, update unit test

* fix some images, update unit test

* integration test fixes
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

kokoro:force-run forces a kokoro re-run on a PR size/S

2 participants