fix: update gcr.io/kpt-fn/ to ghcr.io/kptdev/krm-functions-catalog fo…#10020
Conversation
…r the kpt transformers
Summary of ChangesHello, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed! This pull request addresses a critical issue where KRM function images were moved to a new registry. By updating the image paths, it ensures the continued functionality of KRM transformers within Skaffold, preventing disruptions caused by broken image references. Highlights
🧠 New Feature in Public Preview: You can now enable Memory to help Gemini Code Assist learn from your team's feedback. This makes future code reviews more consistent and personalized to your project's style. Click here to enable Memory in your admin console. Using Gemini Code AssistThe full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips. Invoking Gemini You can request assistance from Gemini at any point by creating a comment using either
Customization To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a Limitations & Feedback Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for GitHub and other Google products, sign up here. Footnotes
|
There was a problem hiding this comment.
Code Review
The pull request successfully updates the image registry paths for KRM functions from gcr.io/kpt-fn/ to ghcr.io/kptdev/krm-functions-catalog/ in pkg/skaffold/render/transform/transform.go. This change directly addresses the issue of deprecated image locations, ensuring the application uses the correct function images. For future maintainability, consider refactoring the repeated image prefix into a package-level constant.
| transformerAllowlist = map[string]kptfile.Function{ | ||
| "set-namespace": { | ||
| Image: "gcr.io/kpt-fn/set-namespace:v0.4.1", | ||
| Image: "ghcr.io/kptdev/krm-functions-catalog/set-namespace:v0.4.1", |
There was a problem hiding this comment.
The string "ghcr.io/kptdev/krm-functions-catalog/" is repeated across multiple Image fields within the transformerAllowlist map. To improve maintainability and reduce redundancy, consider defining this common prefix as a package-level constant. This would simplify future updates if the base registry path changes again, requiring only a single modification.
GoogleContainerTools#10020) * fix: update gcr.io/kpt-fn/ to ghcr.io/kptdev/krm-functions-catalog for the kpt transformers * fix some images, update unit test * fix some images, update unit test * integration test fixes
fix: update gcr.io/kpt-fn/ to ghcr.io/kptdev/krm-functions-catalog fo… (#10020) * fix: update gcr.io/kpt-fn/ to ghcr.io/kptdev/krm-functions-catalog for the kpt transformers * fix some images, update unit test * fix some images, update unit test * integration test fixes Co-authored-by: menahyouyeah <minnah@google.com>
GoogleContainerTools#10020) * fix: update gcr.io/kpt-fn/ to ghcr.io/kptdev/krm-functions-catalog for the kpt transformers * fix some images, update unit test * fix some images, update unit test * integration test fixes (cherry picked from commit c143747)
GoogleContainerTools#10020) * fix: update gcr.io/kpt-fn/ to ghcr.io/kptdev/krm-functions-catalog for the kpt transformers * fix some images, update unit test * fix some images, update unit test * integration test fixes
Fixes: #10019
Description
The KRM function images were removed from ghcr.io/kpt-fn on March 13th. Updating them to use the new ghcr.io/kptdev/krm-functions-catalog