Skip to content

fix(helm): Make Helm 4 plugin version a semver string#10047

Merged
ChrisGe4 merged 1 commit into
GoogleContainerTools:mainfrom
AndiDog:helm-4-plugin-version-fix
Apr 13, 2026
Merged

fix(helm): Make Helm 4 plugin version a semver string#10047
ChrisGe4 merged 1 commit into
GoogleContainerTools:mainfrom
AndiDog:helm-4-plugin-version-fix

Conversation

@AndiDog

@AndiDog AndiDog commented Apr 13, 2026

Copy link
Copy Markdown
Contributor

Fixes: #10046

Description

The value must now be semver (breaking change). The value is still required, so I couldn't just remove it. This change works for an older Helm v4.x and for the latest v4.1.4.

@AndiDog AndiDog requested a review from a team as a code owner April 13, 2026 05:33

@gemini-code-assist gemini-code-assist Bot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request updates the version string in the Helm PostRendererTemplate from "0.1" to "0.1.0" in pkg/skaffold/helm/bin.go. I have no feedback to provide.

@ChrisGe4 ChrisGe4 enabled auto-merge (squash) April 13, 2026 16:05
@ChrisGe4 ChrisGe4 merged commit d1b2d1c into GoogleContainerTools:main Apr 13, 2026
11 checks passed
@mrsimonemms

mrsimonemms commented Apr 15, 2026

Copy link
Copy Markdown

When might this be released? It looks like it just missed the cut on the last release

@mattsanta

Copy link
Copy Markdown
Contributor

@mrsimonemms We'll cut a new release early next week.

orospakr pushed a commit to orospakr/skaffold-spawnexec that referenced this pull request May 14, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

4 participants