Skip to content

chore: skaffold/v4beta14 creation#10059

Merged
alphanota merged 1 commit into
mainfrom
new_release
Apr 22, 2026
Merged

chore: skaffold/v4beta14 creation#10059
alphanota merged 1 commit into
mainfrom
new_release

Conversation

@Darien-Lin

Copy link
Copy Markdown
Contributor

Creation of the new config version so contributors can add to the struct.

@Darien-Lin Darien-Lin requested a review from a team as a code owner April 22, 2026 15:40
Abrahami2
Abrahami2 previously approved these changes Apr 22, 2026

@Abrahami2 Abrahami2 left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@gemini-code-assist gemini-code-assist Bot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request updates the Skaffold configuration version from v4beta13 to v4beta14, transitioning the previous latest schema to a fixed version and updating all examples and integration tests. It also adds Docker-based documentation preview environments. Review feedback points out build-breaking invalid versions for Hugo and Kubernetes in the new Dockerfiles, recommends replacing obsolete base images, and warns of potential runtime errors due to inconsistent Node.js versions in multi-stage builds.

Comment thread deploy/docs-v2/Dockerfile
Comment thread deploy/docs-v2/Dockerfile
Comment thread deploy/docs-v2/Dockerfile
Comment thread deploy/docs-v2/Dockerfile
Comment thread deploy/docs-v1/Dockerfile
alphanota
alphanota previously approved these changes Apr 22, 2026
@alphanota alphanota self-assigned this Apr 22, 2026
@alphanota alphanota enabled auto-merge (squash) April 22, 2026 17:49
@alphanota alphanota self-requested a review April 22, 2026 17:49
@alphanota alphanota merged commit 1e81e04 into main Apr 22, 2026
16 of 24 checks passed
@alphanota alphanota deleted the new_release branch April 22, 2026 17:50
orospakr pushed a commit to orospakr/skaffold-spawnexec that referenced this pull request May 14, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

3 participants