feat: context copy retry. If we add a for loop and execute the kubectlcli.Run method for copying context to kaniko pod , this makes more reliable and less prune to network failures

[santinoncs]

• If we add a for loop and execute the kubectlcli.Run method for copying context to kaniko pod , this makes more reliable and less prune to network failures

[conventional-commit-lint-gcf]

🤖 I detect that the PR title and the commit message differ and there's only one commit. To use the PR title for the commit history, you can use Github's automerge feature with squashing, or use automerge label. Good luck human!

-- conventional-commit-lint bot
https://conventionalcommits.org/

[aaron-prindle]

nit: can you make this a const and put it at the top of the file? Thanks!

[aaron-prindle]

Thanks for the PR @santinoncs, left one nit comment. Once we resolve that we should be able to merge

[santinoncs]

Thanks for the PR @santinoncs, left one nit comment. Once we resolve that we should be able to merge

thanks!
done

[codecov]

Codecov Report

Merging #7887 (18fba71) into main (290280e) will decrease coverage by 3.62%.
The diff coverage is 53.94%.

@@            Coverage Diff             @@
##             main    #7887      +/-   ##
==========================================
- Coverage   70.48%   66.85%   -3.63%     
==========================================
  Files         515      594      +79     
  Lines       23150    28764    +5614     
==========================================
+ Hits        16317    19230    +2913     
- Misses       5776     8123    +2347     
- Partials     1057     1411     +354     

Impacted Files	Coverage Δ
cmd/skaffold/app/cmd/credits/export.go	0.00% <0.00%> (ø)
cmd/skaffold/app/cmd/deploy.go	40.90% <0.00%> (-12.94%)	⬇️
cmd/skaffold/app/cmd/test.go	44.44% <0.00%> (ø)
cmd/skaffold/skaffold.go	0.00% <0.00%> (ø)
cmd/skaffold/app/cmd/inspect_tests.go	62.50% <14.28%> (-1.14%)	⬇️
cmd/skaffold/app/cmd/render.go	35.48% <18.18%> (-5.90%)	⬇️
cmd/skaffold/app/cmd/lsp.go	28.12% <28.12%> (ø)
cmd/skaffold/app/cmd/run.go	64.28% <33.33%> (-9.63%)	⬇️
cmd/skaffold/app/cmd/fix.go	56.41% <37.50%> (-20.07%)	⬇️
cmd/skaffold/app/cmd/verify.go	41.17% <41.17%> (ø)
... and 369 more

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

[tejal29]

This change looks good to me. However can we change the implementation to wire backoff mechanism like elsewhere in the code?

skaffold/pkg/skaffold/docker/logger/log.go

Line 132 in 34f48f7

if waitErr := wait.Poll(backoff.Duration, RetryTimeout, func() (bool, error) {

This will ensure, the code waits before the next attempt.

[aaron-prindle]

Seems there is linter error preventing merge atm:

kg/skaffold/build/cluster/kaniko.go:147: unnecessary trailing newline (whitespace)

	}
FAILED hack/golangci-lint.sh

I think you you remove that newline we can merge 🎊

[santinoncs]

can we merge? thanks!

[santinoncs]

Hi @tejal29

is there any reason we cannot merge this? sorry and thank you!

[aaron-prindle]

Sorry for the delay @santinoncs, merging this now. Thanks for the fix!