Skip to content

fix: revert "fix: no longer pass os env vars through to verify as thiss can cause unexpected issues with PATH, GOPATH, etc (#7949)"#7998

Merged
aaron-prindle merged 1 commit into
GoogleContainerTools:mainfrom
aaron-prindle:revert-7949
Oct 27, 2022
Merged

fix: revert "fix: no longer pass os env vars through to verify as thiss can cause unexpected issues with PATH, GOPATH, etc (#7949)"#7998
aaron-prindle merged 1 commit into
GoogleContainerTools:mainfrom
aaron-prindle:revert-7949

Conversation

@aaron-prindle

Copy link
Copy Markdown
Contributor

This reverts commit 0365e15.

…s can cause unexpected issues with PATH, GOPATH, etc (GoogleContainerTools#7949)"

This reverts commit 0365e15.
@aaron-prindle aaron-prindle enabled auto-merge (squash) October 27, 2022 20:44
@aaron-prindle aaron-prindle mentioned this pull request Oct 27, 2022
@codecov

codecov Bot commented Oct 27, 2022

Copy link
Copy Markdown

Codecov Report

Merging #7998 (e55108e) into main (290280e) will decrease coverage by 3.84%.
The diff coverage is 54.09%.

@@            Coverage Diff             @@
##             main    #7998      +/-   ##
==========================================
- Coverage   70.48%   66.63%   -3.85%     
==========================================
  Files         515      596      +81     
  Lines       23150    28890    +5740     
==========================================
+ Hits        16317    19251    +2934     
- Misses       5776     8208    +2432     
- Partials     1057     1431     +374     
Impacted Files Coverage Δ
cmd/skaffold/app/cmd/credits/export.go 0.00% <0.00%> (ø)
cmd/skaffold/app/cmd/deploy.go 40.90% <0.00%> (-12.94%) ⬇️
cmd/skaffold/app/cmd/test.go 44.44% <0.00%> (ø)
cmd/skaffold/app/exitcode.go 100.00% <ø> (+6.66%) ⬆️
cmd/skaffold/skaffold.go 0.00% <0.00%> (ø)
cmd/skaffold/app/cmd/inspect_tests.go 62.50% <14.28%> (-1.14%) ⬇️
cmd/skaffold/app/cmd/render.go 35.48% <18.18%> (-5.90%) ⬇️
cmd/skaffold/app/cmd/lsp.go 28.12% <28.12%> (ø)
cmd/skaffold/app/cmd/run.go 64.28% <33.33%> (-9.63%) ⬇️
cmd/skaffold/app/cmd/fix.go 56.41% <37.50%> (-20.07%) ⬇️
... and 388 more

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@aaron-prindle aaron-prindle merged commit 171ed58 into GoogleContainerTools:main Oct 27, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

2 participants