feat: add skipTests to ignore helm test directory on manifest generation#8011
Merged
aaron-prindle merged 1 commit intoNov 4, 2022
Merged
Conversation
Codecov Report
@@ Coverage Diff @@
## main #8011 +/- ##
==========================================
- Coverage 70.48% 66.61% -3.88%
==========================================
Files 515 598 +83
Lines 23150 28986 +5836
==========================================
+ Hits 16317 19308 +2991
- Misses 5776 8252 +2476
- Partials 1057 1426 +369
📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
Signed-off-by: Imre Nagi <imre.nagi@gojek.com>
ea71002 to
5bac4f3
Compare
Contributor
Author
|
hi @tejal29 can you please help review or assign reviewer for this PR? Thanks! |
aaron-prindle
approved these changes
Nov 4, 2022
aaron-prindle
left a comment
Contributor
There was a problem hiding this comment.
LGTM, thanks for this @imrenagi!
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes: #5132
Description
This PR add new
deploy.helm.releases[*].skipTeststo the configuration file. This is to prevent skaffold from rendering the helm template located on tests directory.User facing changes (remove if N/A)
User can skip helm tests when using helm to deploy the application.
Signed-off-by: Imre Nagi imre.nagi@gojek.com