Skip to content

feat: add skipTests to ignore helm test directory on manifest generation#8011

Merged
aaron-prindle merged 1 commit into
GoogleContainerTools:mainfrom
imrenagi:feat/helm-skip-test
Nov 4, 2022
Merged

feat: add skipTests to ignore helm test directory on manifest generation#8011
aaron-prindle merged 1 commit into
GoogleContainerTools:mainfrom
imrenagi:feat/helm-skip-test

Conversation

@imrenagi

Copy link
Copy Markdown
Contributor

Fixes: #5132

Description
This PR add new deploy.helm.releases[*].skipTests to the configuration file. This is to prevent skaffold from rendering the helm template located on tests directory.

User facing changes (remove if N/A)
User can skip helm tests when using helm to deploy the application.

apiVersion: skaffold/v3
kind: Config
metadata:
  name: waterfight
profiles:
 - name: helm
    deploy:
      helm:
        releases:
          - name: waterfight-skaffold-k8s
            chartPath: deployment/helm/app
            namespace: default
            skipTests: true

Signed-off-by: Imre Nagi imre.nagi@gojek.com

@codecov

codecov Bot commented Nov 1, 2022

Copy link
Copy Markdown

Codecov Report

Merging #8011 (5bac4f3) into main (290280e) will decrease coverage by 3.87%.
The diff coverage is 54.09%.

@@            Coverage Diff             @@
##             main    #8011      +/-   ##
==========================================
- Coverage   70.48%   66.61%   -3.88%     
==========================================
  Files         515      598      +83     
  Lines       23150    28986    +5836     
==========================================
+ Hits        16317    19308    +2991     
- Misses       5776     8252    +2476     
- Partials     1057     1426     +369     
Impacted Files Coverage Δ
cmd/skaffold/app/cmd/credits/export.go 0.00% <0.00%> (ø)
cmd/skaffold/app/cmd/deploy.go 40.90% <0.00%> (-12.94%) ⬇️
cmd/skaffold/app/cmd/test.go 44.44% <0.00%> (ø)
cmd/skaffold/app/exitcode.go 100.00% <ø> (+6.66%) ⬆️
cmd/skaffold/skaffold.go 0.00% <0.00%> (ø)
cmd/skaffold/app/cmd/inspect_tests.go 62.50% <14.28%> (-1.14%) ⬇️
cmd/skaffold/app/cmd/render.go 35.48% <18.18%> (-5.90%) ⬇️
cmd/skaffold/app/cmd/lsp.go 28.12% <28.12%> (ø)
cmd/skaffold/app/cmd/run.go 64.28% <33.33%> (-9.63%) ⬇️
cmd/skaffold/app/cmd/fix.go 56.41% <37.50%> (-20.07%) ⬇️
... and 392 more

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@imrenagi imrenagi force-pushed the feat/helm-skip-test branch from ea71002 to 5bac4f3 Compare November 4, 2022 03:59
@imrenagi

imrenagi commented Nov 4, 2022

Copy link
Copy Markdown
Contributor Author

hi @tejal29 can you please help review or assign reviewer for this PR? Thanks!

@aaron-prindle aaron-prindle self-requested a review November 4, 2022 05:44

@aaron-prindle aaron-prindle left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks for this @imrenagi!

@aaron-prindle aaron-prindle merged commit f673fb9 into GoogleContainerTools:main Nov 4, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

2 participants