Skip to content

fix: cleanup not called when using helm deployer alone#8040

Merged
ericzzzzzzz merged 2 commits into
GoogleContainerTools:mainfrom
ericzzzzzzz:8033-fix
Nov 7, 2022
Merged

fix: cleanup not called when using helm deployer alone#8040
ericzzzzzzz merged 2 commits into
GoogleContainerTools:mainfrom
ericzzzzzzz:8033-fix

Conversation

@ericzzzzzzz

@ericzzzzzzz ericzzzzzzz commented Nov 4, 2022

Copy link
Copy Markdown
Contributor

Fixes: #8033
Related: Relevant tracking issues, for context
Merge before/after: Dependent or prerequisite PRs

Description

  • deployment can happen without user specifies manifest then deployedManifests will be empty, so in this pr, change dev command to always call cleanup.
@codecov

codecov Bot commented Nov 4, 2022

Copy link
Copy Markdown

Codecov Report

Merging #8040 (107061e) into main (290280e) will decrease coverage by 3.92%.
The diff coverage is 53.92%.

@@            Coverage Diff             @@
##             main    #8040      +/-   ##
==========================================
- Coverage   70.48%   66.55%   -3.93%     
==========================================
  Files         515      598      +83     
  Lines       23150    29032    +5882     
==========================================
+ Hits        16317    19323    +3006     
- Misses       5776     8280    +2504     
- Partials     1057     1429     +372     
Impacted Files Coverage Δ
cmd/skaffold/app/cmd/credits/export.go 0.00% <0.00%> (ø)
cmd/skaffold/app/cmd/deploy.go 40.90% <0.00%> (-12.94%) ⬇️
cmd/skaffold/app/cmd/test.go 44.44% <0.00%> (ø)
cmd/skaffold/app/exitcode.go 100.00% <ø> (+6.66%) ⬆️
cmd/skaffold/skaffold.go 0.00% <0.00%> (ø)
cmd/skaffold/app/cmd/inspect_tests.go 62.50% <14.28%> (-1.14%) ⬇️
cmd/skaffold/app/cmd/render.go 35.48% <18.18%> (-5.90%) ⬇️
cmd/skaffold/app/cmd/lsp.go 28.12% <28.12%> (ø)
cmd/skaffold/app/cmd/run.go 64.28% <33.33%> (-9.63%) ⬇️
cmd/skaffold/app/cmd/fix.go 56.41% <37.50%> (-20.07%) ⬇️
... and 393 more

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

Comment thread examples/helm-deployment/skaffold.yaml
@pull-request-size pull-request-size Bot added size/L and removed size/S labels Nov 4, 2022
@tejal29

tejal29 commented Nov 4, 2022

Copy link
Copy Markdown
Contributor

just a nit. I think can use profiles to override the skaffold.yaml to use helm deployer.

Thanks
Tejal

@ericzzzzzzz ericzzzzzzz merged commit 00ae5e6 into GoogleContainerTools:main Nov 7, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

2 participants