Skip to content

chore: fix gcloud install with latest ubuntu#8153

Merged
aaron-prindle merged 1 commit into
GoogleContainerTools:mainfrom
ericzzzzzzz:fix-gcloud-install-with-latest-ubuntu
Nov 28, 2022
Merged

chore: fix gcloud install with latest ubuntu#8153
aaron-prindle merged 1 commit into
GoogleContainerTools:mainfrom
ericzzzzzzz:fix-gcloud-install-with-latest-ubuntu

Conversation

@ericzzzzzzz

@ericzzzzzzz ericzzzzzzz commented Nov 24, 2022

Copy link
Copy Markdown
Contributor

Fixes: #8137

updating strategy matrix causes ci jobs stuck.. that might also happen if we update top level info in workflow file, I think we probably need admin power to merge this pr. #8117 has the same issue,

@ericzzzzzzz ericzzzzzzz marked this pull request as draft November 24, 2022 01:33
@ericzzzzzzz ericzzzzzzz force-pushed the fix-gcloud-install-with-latest-ubuntu branch from 1f79023 to f10f204 Compare November 24, 2022 01:39
@codecov

codecov Bot commented Nov 24, 2022

Copy link
Copy Markdown

Codecov Report

Merging #8153 (83c4c64) into main (290280e) will decrease coverage by 4.26%.
The diff coverage is 53.26%.

❗ Current head 83c4c64 differs from pull request most recent head e26b8c6. Consider uploading reports for the commit e26b8c6 to get more accurate results

@@            Coverage Diff             @@
##             main    #8153      +/-   ##
==========================================
- Coverage   70.48%   66.22%   -4.27%     
==========================================
  Files         515      599      +84     
  Lines       23150    29346    +6196     
==========================================
+ Hits        16317    19434    +3117     
- Misses       5776     8458    +2682     
- Partials     1057     1454     +397     
Impacted Files Coverage Δ
cmd/skaffold/app/cmd/completion.go 13.04% <0.00%> (-1.25%) ⬇️
cmd/skaffold/app/cmd/credits/export.go 0.00% <0.00%> (ø)
cmd/skaffold/app/cmd/deploy.go 40.90% <0.00%> (-12.94%) ⬇️
cmd/skaffold/app/cmd/test.go 44.44% <0.00%> (ø)
cmd/skaffold/app/exitcode.go 100.00% <ø> (+6.66%) ⬆️
cmd/skaffold/skaffold.go 0.00% <0.00%> (ø)
cmd/skaffold/app/cmd/inspect_tests.go 62.50% <14.28%> (-1.14%) ⬇️
cmd/skaffold/app/cmd/render.go 35.48% <18.18%> (-5.90%) ⬇️
cmd/skaffold/app/cmd/lsp.go 28.12% <28.12%> (ø)
cmd/skaffold/app/cmd/run.go 64.28% <33.33%> (-9.63%) ⬇️
... and 392 more

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@ericzzzzzzz ericzzzzzzz force-pushed the fix-gcloud-install-with-latest-ubuntu branch from 37279f4 to 04a6e1d Compare November 24, 2022 13:11
@ericzzzzzzz

ericzzzzzzz commented Nov 24, 2022

Copy link
Copy Markdown
Contributor Author
  • updating strategy matrix causes ci jobs stuck.. that might also happen if we update top level info in workflow file, I think we probably need admin power to merge this pr.
@ericzzzzzzz ericzzzzzzz marked this pull request as ready for review November 24, 2022 13:16
@ericzzzzzzz ericzzzzzzz force-pushed the fix-gcloud-install-with-latest-ubuntu branch from 04a6e1d to 228209a Compare November 25, 2022 15:36
@ericzzzzzzz ericzzzzzzz force-pushed the fix-gcloud-install-with-latest-ubuntu branch from 228209a to e26b8c6 Compare November 28, 2022 12:53
@ericzzzzzzz

Copy link
Copy Markdown
Contributor Author

Hi @tejal29 can I get your 👀 on this pr ? The some github checks got stuck due to changes made in workflow file, I think I may need you to approve and merge it. @aaron-prindle approved this before, but I was not able to merge it :(

@aaron-prindle

Copy link
Copy Markdown
Contributor

I also can't merge this with the current Github settings ( I believe I have the same access)

@aaron-prindle aaron-prindle merged commit 125e791 into GoogleContainerTools:main Nov 28, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

2 participants