fix: expand namespace with env variables#8222
Merged
Merged
Conversation
8fb71c8 to
7f67859
Compare
Codecov Report
@@ Coverage Diff @@
## main #8222 +/- ##
==========================================
- Coverage 70.48% 66.12% -4.36%
==========================================
Files 515 601 +86
Lines 23150 29483 +6333
==========================================
+ Hits 16317 19497 +3180
- Misses 5776 8527 +2751
- Partials 1057 1459 +402
📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
7f67859 to
81dd6e4
Compare
81dd6e4 to
d6efa0e
Compare
aaron-prindle
pushed a commit
to aaron-prindle/skaffold
that referenced
this pull request
Dec 20, 2022
* fix: expand namespace with env variables * test: integration test for defaultNamespace config
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes: #8183
Description
Now, before returning the namespace from the runcontext, we replace the env variables if any is present.