Skip to content

feat: get image digest from container logs for kaniko builder#8264

Merged
gsquared94 merged 1 commit into
GoogleContainerTools:mainfrom
gsquared94:fix-8099
Dec 21, 2022
Merged

feat: get image digest from container logs for kaniko builder#8264
gsquared94 merged 1 commit into
GoogleContainerTools:mainfrom
gsquared94:fix-8099

Conversation

@gsquared94

@gsquared94 gsquared94 commented Dec 20, 2022

Copy link
Copy Markdown
Contributor

Fixes: #8099

Description

This PR modifies kaniko builder to run with the --digest-file flag that can be used to get the image digest from the kubernetes logs instead of connecting to the image registry locally.

Testing instructions

  • Stop the local docker daemon.
  • Set kubernetes context to a cluster with kaniko setup. Maintainers can use the integration-tests GKE cluster.
  • Run skaffold dev --cache-artifacts=false --default-repo=<your-image-registry> from the examples/kaniko project
  • The image should be successfully built and pushed to the container registy, and deployed to the active kubernetes cluster.
@codecov

codecov Bot commented Dec 20, 2022

Copy link
Copy Markdown

Codecov Report

Merging #8264 (406686d) into main (290280e) will decrease coverage by 4.39%.
The diff coverage is 54.68%.

@@            Coverage Diff             @@
##             main    #8264      +/-   ##
==========================================
- Coverage   70.48%   66.08%   -4.40%     
==========================================
  Files         515      601      +86     
  Lines       23150    29506    +6356     
==========================================
+ Hits        16317    19500    +3183     
- Misses       5776     8544    +2768     
- Partials     1057     1462     +405     
Impacted Files Coverage Δ
cmd/skaffold/app/cmd/completion.go 13.04% <0.00%> (-1.25%) ⬇️
cmd/skaffold/app/cmd/config/list.go 65.21% <ø> (ø)
cmd/skaffold/app/cmd/config/set.go 88.72% <ø> (ø)
cmd/skaffold/app/cmd/config/util.go 54.28% <ø> (ø)
cmd/skaffold/app/cmd/credits.go 100.00% <ø> (ø)
cmd/skaffold/app/cmd/credits/export.go 0.00% <0.00%> (ø)
cmd/skaffold/app/cmd/deploy.go 40.90% <0.00%> (-12.94%) ⬇️
cmd/skaffold/app/cmd/generate_pipeline.go 60.00% <ø> (ø)
cmd/skaffold/app/cmd/inspect_modules.go 65.00% <ø> (ø)
cmd/skaffold/app/cmd/inspect_profiles.go 66.66% <ø> (ø)
... and 405 more

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

Comment thread pkg/skaffold/build/kaniko/args.go Outdated

@aaron-prindle aaron-prindle left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@gsquared94 gsquared94 merged commit 8b1d10b into GoogleContainerTools:main Dec 21, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

3 participants