Skip to content

Handle StatefulSets with an OnDelete update strategy#8292

Merged
gsquared94 merged 1 commit into
GoogleContainerTools:mainfrom
hach-que:statefulset-ondelete
Jan 20, 2023
Merged

Handle StatefulSets with an OnDelete update strategy#8292
gsquared94 merged 1 commit into
GoogleContainerTools:mainfrom
hach-que:statefulset-ondelete

Conversation

@hach-que

@hach-que hach-que commented Jan 3, 2023

Copy link
Copy Markdown
Contributor

Fixes: #7589

@codecov

codecov Bot commented Jan 4, 2023

Copy link
Copy Markdown

Codecov Report

Merging #8292 (1b0f3e7) into main (290280e) will decrease coverage by 4.41%.
The diff coverage is 54.68%.

@@            Coverage Diff             @@
##             main    #8292      +/-   ##
==========================================
- Coverage   70.48%   66.08%   -4.41%     
==========================================
  Files         515      605      +90     
  Lines       23150    29658    +6508     
==========================================
+ Hits        16317    19599    +3282     
- Misses       5776     8591    +2815     
- Partials     1057     1468     +411     
Impacted Files Coverage Δ
cmd/skaffold/app/cmd/completion.go 13.04% <0.00%> (-1.25%) ⬇️
cmd/skaffold/app/cmd/config/list.go 65.21% <ø> (ø)
cmd/skaffold/app/cmd/config/set.go 88.72% <ø> (ø)
cmd/skaffold/app/cmd/config/util.go 54.28% <ø> (ø)
cmd/skaffold/app/cmd/credits.go 100.00% <ø> (ø)
cmd/skaffold/app/cmd/credits/export.go 0.00% <0.00%> (ø)
cmd/skaffold/app/cmd/deploy.go 40.90% <0.00%> (-12.94%) ⬇️
cmd/skaffold/app/cmd/generate_pipeline.go 60.00% <ø> (ø)
cmd/skaffold/app/cmd/inspect_modules.go 65.00% <ø> (ø)
cmd/skaffold/app/cmd/inspect_profiles.go 66.66% <ø> (ø)
... and 416 more

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@aaron-prindle

aaron-prindle commented Jan 4, 2023

Copy link
Copy Markdown
Contributor

@hach-que thanks for the PR here! Can you change you commit message to adhere to Conventional Commits format - eg:
"Handle StatefulSets with an OnDelete update strategy" -> "fix: Handle StatefulSets with an OnDelete update strategy"
(adding the fix: prefix)

Currently a CI/CD test is failing due to this - conventionalcommits.org test

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

3 participants