Skip to content

fix: write maximum of 200 metrics per session#8294

Merged
gsquared94 merged 1 commit into
GoogleContainerTools:mainfrom
gsquared94:fix-8276
Jan 4, 2023
Merged

fix: write maximum of 200 metrics per session#8294
gsquared94 merged 1 commit into
GoogleContainerTools:mainfrom
gsquared94:fix-8276

Conversation

@gsquared94

Copy link
Copy Markdown
Contributor

Fixes: #8276

Description

Per run of skaffold limit the number of metrics recorded to 200 which is the limit in a single request (https://cloud.google.com/monitoring/quotas). To do multiple requests would require a 10 second pause which will not be a good experience to wait for minutes at the end of a skaffold session.

@codecov

codecov Bot commented Jan 4, 2023

Copy link
Copy Markdown

Codecov Report

Merging #8294 (6797c90) into main (290280e) will decrease coverage by 4.39%.
The diff coverage is 54.68%.

@@            Coverage Diff             @@
##             main    #8294      +/-   ##
==========================================
- Coverage   70.48%   66.08%   -4.40%     
==========================================
  Files         515      602      +87     
  Lines       23150    29520    +6370     
==========================================
+ Hits        16317    19509    +3192     
- Misses       5776     8546    +2770     
- Partials     1057     1465     +408     
Impacted Files Coverage Δ
cmd/skaffold/app/cmd/completion.go 13.04% <0.00%> (-1.25%) ⬇️
cmd/skaffold/app/cmd/config/list.go 65.21% <ø> (ø)
cmd/skaffold/app/cmd/config/set.go 88.72% <ø> (ø)
cmd/skaffold/app/cmd/config/util.go 54.28% <ø> (ø)
cmd/skaffold/app/cmd/credits.go 100.00% <ø> (ø)
cmd/skaffold/app/cmd/credits/export.go 0.00% <0.00%> (ø)
cmd/skaffold/app/cmd/deploy.go 40.90% <0.00%> (-12.94%) ⬇️
cmd/skaffold/app/cmd/generate_pipeline.go 60.00% <ø> (ø)
cmd/skaffold/app/cmd/inspect_modules.go 65.00% <ø> (ø)
cmd/skaffold/app/cmd/inspect_profiles.go 66.66% <ø> (ø)
... and 405 more

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@aaron-prindle aaron-prindle left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@gsquared94 gsquared94 merged commit 5c5b502 into GoogleContainerTools:main Jan 4, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

2 participants