Skip to content

docs: update docs for new runtimeType field#8298

Merged
gsquared94 merged 1 commit into
GoogleContainerTools:mainfrom
gsquared94:fix-2203-docs
Jan 5, 2023
Merged

docs: update docs for new runtimeType field#8298
gsquared94 merged 1 commit into
GoogleContainerTools:mainfrom
gsquared94:fix-2203-docs

Conversation

@gsquared94

Copy link
Copy Markdown
Contributor

Merge after: #8295

Description

Update docs for #8295

@aaron-prindle

Copy link
Copy Markdown
Contributor

I think tests will pass now that #8295 is merged if you rebase

@codecov

codecov Bot commented Jan 5, 2023

Copy link
Copy Markdown

Codecov Report

Merging #8298 (f78c0f2) into main (290280e) will decrease coverage by 4.41%.
The diff coverage is 54.96%.

@@            Coverage Diff             @@
##             main    #8298      +/-   ##
==========================================
- Coverage   70.48%   66.06%   -4.42%     
==========================================
  Files         515      603      +88     
  Lines       23150    29556    +6406     
==========================================
+ Hits        16317    19526    +3209     
- Misses       5776     8565    +2789     
- Partials     1057     1465     +408     
Impacted Files Coverage Δ
cmd/skaffold/app/cmd/completion.go 13.04% <0.00%> (-1.25%) ⬇️
cmd/skaffold/app/cmd/config/list.go 65.21% <ø> (ø)
cmd/skaffold/app/cmd/config/set.go 88.72% <ø> (ø)
cmd/skaffold/app/cmd/config/util.go 54.28% <ø> (ø)
cmd/skaffold/app/cmd/credits.go 100.00% <ø> (ø)
cmd/skaffold/app/cmd/credits/export.go 0.00% <0.00%> (ø)
cmd/skaffold/app/cmd/deploy.go 40.90% <0.00%> (-12.94%) ⬇️
cmd/skaffold/app/cmd/generate_pipeline.go 60.00% <ø> (ø)
cmd/skaffold/app/cmd/inspect_modules.go 65.00% <ø> (ø)
cmd/skaffold/app/cmd/inspect_profiles.go 66.66% <ø> (ø)
... and 411 more

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@aaron-prindle aaron-prindle left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@gsquared94 gsquared94 merged commit 420b790 into GoogleContainerTools:main Jan 5, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

2 participants