feat: add new inspect namespaces list command to skaffold#8309
Merged
Conversation
aaron-prindle
force-pushed
the
fix-8191
branch
4 times, most recently
from
4564147 to
5b7c494
Compare
Codecov Report
@@ Coverage Diff @@
## main #8309 +/- ##
==========================================
- Coverage 70.48% 66.08% -4.41%
==========================================
Files 515 605 +90
Lines 23150 29654 +6504
==========================================
+ Hits 16317 19596 +3279
- Misses 5776 8590 +2814
- Partials 1057 1468 +411
📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
aaron-prindle
force-pushed
the
fix-8191
branch
from
5b7c494 to
46ca4ce
Compare
aaron-prindle
force-pushed
the
fix-8191
branch
6 times, most recently
from
9e1ef67 to
b2f12f2
Compare
renzodavid9
reviewed
Jan 12, 2023
|
|
||
| func cmdNamespaces() *cobra.Command { | ||
| return NewCmd("namespaces"). | ||
| WithDescription("View skaffold test information"). |
Contributor
There was a problem hiding this comment.
I think this is the description from skaffold inspect tests, do we need to change it for skaffold inspect namespaces?
Contributor
Author
There was a problem hiding this comment.
Good catch thanks, updated now
aaron-prindle
force-pushed
the
fix-8191
branch
2 times, most recently
from
a8eba58 to
fb9ef23
Compare
renzodavid9
reviewed
Jan 12, 2023
| description: "print all deployment namespaces where no namespace is set in manifest(s) or deploy config", | ||
| manifest: manifest, | ||
| expected: `{"resourceToInfoMap":{"apps/v1, Kind=Deployment":[{"name":"leeroy-app","namespace":"default"}]}}` + "\n", | ||
| // expected: `` + "\n", |
Contributor
Author
There was a problem hiding this comment.
Ah good catch sorry. Removed now
renzodavid9
approved these changes
Jan 12, 2023
aaron-prindle
force-pushed
the
fix-8191
branch
from
fb9ef23 to
436da8d
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
fixes #8191