Skip to content

feat: change components installed in docker images to include alpha and beta#8314

Merged
aaron-prindle merged 1 commit into
mainfrom
issue-8110
Jan 12, 2023
Merged

feat: change components installed in docker images to include alpha and beta#8314
aaron-prindle merged 1 commit into
mainfrom
issue-8110

Conversation

@renzodavid9

@renzodavid9 renzodavid9 commented Jan 11, 2023

Copy link
Copy Markdown
Contributor

Fixes: #8110

Description
Add alpha and beta gcloud components that include logs and proxy services, needed to perform Cloud Run's log streaming and port forward accordingly.

Follow-up Work
Check when these services move out from alpha and beta to change the code accordingly. Tracking issue #8317:

@codecov

codecov Bot commented Jan 11, 2023

Copy link
Copy Markdown

Codecov Report

Merging #8314 (e3b072e) into main (290280e) will decrease coverage by 4.41%.
The diff coverage is 54.96%.

@@            Coverage Diff             @@
##             main    #8314      +/-   ##
==========================================
- Coverage   70.48%   66.06%   -4.42%     
==========================================
  Files         515      603      +88     
  Lines       23150    29562    +6412     
==========================================
+ Hits        16317    19530    +3213     
- Misses       5776     8568    +2792     
- Partials     1057     1464     +407     
Impacted Files Coverage Δ
cmd/skaffold/app/cmd/completion.go 13.04% <0.00%> (-1.25%) ⬇️
cmd/skaffold/app/cmd/config/list.go 65.21% <ø> (ø)
cmd/skaffold/app/cmd/config/set.go 88.72% <ø> (ø)
cmd/skaffold/app/cmd/config/util.go 54.28% <ø> (ø)
cmd/skaffold/app/cmd/credits.go 100.00% <ø> (ø)
cmd/skaffold/app/cmd/credits/export.go 0.00% <0.00%> (ø)
cmd/skaffold/app/cmd/deploy.go 40.90% <0.00%> (-12.94%) ⬇️
cmd/skaffold/app/cmd/generate_pipeline.go 60.00% <ø> (ø)
cmd/skaffold/app/cmd/inspect_modules.go 65.00% <ø> (ø)
cmd/skaffold/app/cmd/inspect_profiles.go 66.66% <ø> (ø)
... and 414 more

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

…ed for cloud run log steaming and port forward
Comment thread deploy/skaffold/Dockerfile.deps.lts
Comment thread deploy/skaffold/Dockerfile.deps.slim
@aaron-prindle aaron-prindle marked this pull request as ready for review January 12, 2023 18:26

@aaron-prindle aaron-prindle left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@aaron-prindle aaron-prindle merged commit 33af62e into main Jan 12, 2023
@aaron-prindle aaron-prindle deleted the issue-8110 branch January 12, 2023 19:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

2 participants