feat: change components installed in docker images to include alpha and beta#8314
Merged
Conversation
Codecov Report
@@ Coverage Diff @@
## main #8314 +/- ##
==========================================
- Coverage 70.48% 66.06% -4.42%
==========================================
Files 515 603 +88
Lines 23150 29562 +6412
==========================================
+ Hits 16317 19530 +3213
- Misses 5776 8568 +2792
- Partials 1057 1464 +407
📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
…ed for cloud run log steaming and port forward
dd83d51 to
e3b072e
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes: #8110
Description
Add
alphaandbetagcloud components that includelogsandproxyservices, needed to perform Cloud Run's log streaming and port forward accordingly.Follow-up Work
Check when these services move out from
alphaandbetato change the code accordingly. Tracking issue #8317:skaffold/pkg/skaffold/deploy/cloudrun/accessor.go
Line 187 in 8d655cd
skaffold/pkg/skaffold/deploy/cloudrun/log.go
Line 222 in 8d655cd