fix: backport, divide stdout and stderr from helm to not create corrupted outputs#8333
Merged
Conversation
Codecov Report
@@ Coverage Diff @@
## v1 #8333 +/- ##
=====================================
Coverage ? 68.31%
=====================================
Files ? 563
Lines ? 26707
Branches ? 0
=====================================
Hits ? 18246
Misses ? 7186
Partials ? 1275 📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
68a21f7 to
cd09caa
Compare
cd09caa to
ca88d7d
Compare
Contributor
Author
|
How to reproduce the issue Environment
Upload a chart to your local OCI registry
Reproduce the issue
Solve the issue
|
…l` produces same output as `skaffold render &> render.yaml`
aaron-prindle
approved these changes
Jan 19, 2023
aaron-prindle
left a comment
Contributor
There was a problem hiding this comment.
LGTM - Confirmed manually that this is working for me as well via the repro steps provided. Awesome!
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes: #8327
Description
This PR is to backport a v2 fix: using
skaffold renderwith a helm deployer, with helm >= 3.10.2, pulling from an OCI registry is generating a corrupted yaml output, so here we are setting two different buffers, one for stdout and another for stderr to split the messages and differentiate between the generated yaml content and the errors.Related PRs from v2