Skip to content

docs: remove log tailing from note of unsupported features for Cloud Run#8344

Merged
aaron-prindle merged 2 commits into
mainfrom
issue-cloudrun-docs-update
Jan 20, 2023
Merged

docs: remove log tailing from note of unsupported features for Cloud Run#8344
aaron-prindle merged 2 commits into
mainfrom
issue-cloudrun-docs-update

Conversation

@renzodavid9

@renzodavid9 renzodavid9 commented Jan 20, 2023

Copy link
Copy Markdown
Contributor

Related: #8338

Description
Remove log tailing from the unsupported features for Cloud Run, we should support this now for all the cases
@renzodavid9 renzodavid9 added docs-modifications-v2 runs the docs v2 preview service on the given PR docs-modifications runs the docs preview service on the given PR labels Jan 20, 2023
@container-tools-bot

container-tools-bot commented Jan 20, 2023

Copy link
Copy Markdown

Please visit http://34.28.221.57:1313 to view changes to the docs.
@container-tools-bot

container-tools-bot commented Jan 20, 2023

Copy link
Copy Markdown

Error creating deployment, please see controller logs for details.
@container-tools-bot container-tools-bot removed docs-modifications-v2 runs the docs v2 preview service on the given PR labels Jan 20, 2023
@container-tools-bot

container-tools-bot commented Jan 20, 2023

Copy link
Copy Markdown

Error creating deployment docs-controller-deployment-8344, please visit https://storage.googleapis.com/webhook-logs/logs-8344-1674237959791213845 to view logs.
@container-tools-bot container-tools-bot removed the docs-modifications runs the docs preview service on the given PR label Jan 20, 2023
@codecov

codecov Bot commented Jan 20, 2023 •
edited
Loading

Copy link
Copy Markdown

Codecov Report

Merging #8344 (aaece60) into main (290280e) will decrease coverage by 4.60%.
The diff coverage is 54.85%.

@@            Coverage Diff             @@
##             main    #8344      +/-   ##
==========================================
- Coverage   70.48%   65.88%   -4.60%     
==========================================
  Files         515      605      +90     
  Lines       23150    29784    +6634     
==========================================
+ Hits        16317    19624    +3307     
- Misses       5776     8686    +2910     
- Partials     1057     1474     +417
Impacted Files Coverage Δ
cmd/skaffold/app/cmd/completion.go 13.04% <0.00%> (-1.25%) ⬇️
cmd/skaffold/app/cmd/config/list.go 65.21% <ø> (ø)
cmd/skaffold/app/cmd/config/set.go 88.72% <ø> (ø)
cmd/skaffold/app/cmd/config/util.go 54.28% <ø> (ø)
cmd/skaffold/app/cmd/credits.go 100.00% <ø> (ø)
cmd/skaffold/app/cmd/credits/export.go 0.00% <0.00%> (ø)
cmd/skaffold/app/cmd/deploy.go 40.90% <0.00%> (-12.94%) ⬇️
cmd/skaffold/app/cmd/generate_pipeline.go 60.00% <ø> (ø)
cmd/skaffold/app/cmd/inspect_modules.go 65.00% <ø> (ø)
cmd/skaffold/app/cmd/inspect_profiles.go 66.66% <ø> (ø)
... and 415 more

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more
@renzodavid9 renzodavid9 requested review from a team, MarlonGamez and aaron-prindle and removed request for a team January 20, 2023 18:44
@renzodavid9 renzodavid9 marked this pull request as ready for review January 20, 2023 18:44
aaron-prindle
aaron-prindle reviewed Jan 20, 2023
View reviewed changes
Comment thread docs-v2/content/en/docs/pipeline-stages/deployers/cloudrun.md Outdated
@renzodavid9 renzodavid9 added docs-modifications runs the docs preview service on the given PR docs-modifications-v2 runs the docs v2 preview service on the given PR labels Jan 20, 2023
@container-tools-bot

container-tools-bot commented Jan 20, 2023

Copy link
Copy Markdown

Error creating deployment, please see controller logs for details.
1 similar comment
@container-tools-bot

container-tools-bot commented Jan 20, 2023

Copy link
Copy Markdown

Error creating deployment, please see controller logs for details.
@container-tools-bot container-tools-bot removed docs-modifications runs the docs preview service on the given PR docs-modifications-v2 runs the docs v2 preview service on the given PR labels Jan 20, 2023
@container-tools-bot

container-tools-bot commented Jan 20, 2023

Copy link
Copy Markdown

Please visit http://34.28.78.81:1313 to view changes to the docs.
@container-tools-bot

container-tools-bot commented Jan 20, 2023

Copy link
Copy Markdown

Error creating deployment, please see controller logs for details.
@container-tools-bot

container-tools-bot commented Jan 20, 2023

Copy link
Copy Markdown

Error creating deployment docs-controller-deployment-8344, please visit https://storage.googleapis.com/webhook-logs/logs-8344-1674242978366845524 to view logs.
@container-tools-bot

container-tools-bot commented Jan 20, 2023

Copy link
Copy Markdown

Error creating deployment, please see controller logs for details.
aaron-prindle
aaron-prindle approved these changes Jan 20, 2023
View reviewed changes

@aaron-prindle aaron-prindle left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM
@aaron-prindle aaron-prindle merged commit d031227 into main Jan 20, 2023
@aaron-prindle aaron-prindle deleted the issue-cloudrun-docs-update branch January 20, 2023 20:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

size/XS

3 participants

@renzodavid9 @container-tools-bot @aaron-prindle