chore: remove unnecessary code comments#8350
Merged
aaron-prindle merged 1 commit intoFeb 23, 2023
Merged
Conversation
aaron-prindle
force-pushed
the
cleanup-comment
branch
from
46f7a07 to
8a3cb22
Compare
Codecov Report
@@ Coverage Diff @@
## main #8350 +/- ##
==========================================
- Coverage 70.48% 65.21% -5.27%
==========================================
Files 515 603 +88
Lines 23150 29898 +6748
==========================================
+ Hits 16317 19498 +3181
- Misses 5776 8924 +3148
- Partials 1057 1476 +419
📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
aaron-prindle
force-pushed
the
cleanup-comment
branch
from
8a3cb22 to
f17857d
Compare
gsquared94
reviewed
Jan 31, 2023
| if len(resourceYAML) == 0 { | ||
| continue | ||
| } | ||
| // - obj is the API object (e.g., Deployment) |
Contributor
There was a problem hiding this comment.
why are we deleting this comment?
Contributor
Author
There was a problem hiding this comment.
I thought it wasn't necessary (code was self explanatory) initially. I have added back now
aaron-prindle
force-pushed
the
cleanup-comment
branch
3 times, most recently
from
2e692f3 to
193eca7
Compare
aaron-prindle
force-pushed
the
cleanup-comment
branch
from
193eca7 to
0429cdd
Compare
ericzzzzzzz
approved these changes
Feb 23, 2023
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.