fix: resolve issue where verify incorrectly failed when run with multiple modules where any module didn't have verify test cases#8369
Merged
Conversation
…iple modules where any module didn't have verify test cases
8c77f65 to
a2c0bcf
Compare
Codecov Report
@@ Coverage Diff @@
## main #8369 +/- ##
==========================================
- Coverage 70.48% 65.89% -4.60%
==========================================
Files 515 605 +90
Lines 23150 29819 +6669
==========================================
+ Hits 16317 19648 +3331
- Misses 5776 8699 +2923
- Partials 1057 1472 +415
📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
fixes #8368
Repro method:
root
skaffold.yaml/verify-none/skaffold.yaml filebefore fix PRaprindle@aprindle-ssd ~/8368-issue $ skaffold verify
invalid skaffold config: verify command expects non-zero number of test cases
after fix PRaprindle@aprindle-ssd ~/8368-issue $ skaffold verify
Tags used in verification:
latest: Pulling from library/alpine
Digest: sha256:f271e74b17ced29b915d351685fd4644785c6d1559dd1f2d4189a5e851ef753a
Status: Image is up to date for alpine:latest
[alpine] hello