fix: resolve issue where verify validation did not properly validate uniqueness across all modules

[aaron-prindle]

fixes #8372

[codecov]

Codecov Report

Merging #8373 (4045775) into main (290280e) will decrease coverage by 4.59%.
The diff coverage is 54.85%.

@@            Coverage Diff             @@
##             main    #8373      +/-   ##
==========================================
- Coverage   70.48%   65.89%   -4.59%     
==========================================
  Files         515      605      +90     
  Lines       23150    29817    +6667     
==========================================
+ Hits        16317    19649    +3332     
- Misses       5776     8695    +2919     
- Partials     1057     1473     +416     

Impacted Files	Coverage Δ
cmd/skaffold/app/cmd/completion.go	13.04% <0.00%> (-1.25%)	⬇️
cmd/skaffold/app/cmd/config/list.go	65.21% <ø> (ø)
cmd/skaffold/app/cmd/config/set.go	88.72% <ø> (ø)
cmd/skaffold/app/cmd/config/util.go	54.28% <ø> (ø)
cmd/skaffold/app/cmd/credits.go	100.00% <ø> (ø)
cmd/skaffold/app/cmd/credits/export.go	0.00% <0.00%> (ø)
cmd/skaffold/app/cmd/deploy.go	40.90% <0.00%> (-12.94%)	⬇️
cmd/skaffold/app/cmd/generate_pipeline.go	60.00% <ø> (ø)
cmd/skaffold/app/cmd/inspect_modules.go	65.00% <ø> (ø)
cmd/skaffold/app/cmd/inspect_profiles.go	66.66% <ø> (ø)
... and 415 more

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

[gsquared94]

is it possible to get the file name if these verify stanzas are from different skaffold.yaml files?

[aaron-prindle]

I don't believe this information is available in validation.go for skaffold.yaml files. I don't think we have the rel/abs path of the SkaffoldConfig(s) stored in any objects we pass around here (configs, runCtx, etc.). Only the flag runCtx.ConfigurationFile() I believe has something close but that is only the -f <path> value which isn't what we would want. Are you familiar w/ a place this is stored (and that might be accessible here?)

[aaron-prindle]

I don't think it's possible to add the skaffold.yaml files names with the current values we track. Lmk if there is any other changes, etc. to be made here or if you think it is possible and I'm missing something. Thanks!

[gsquared94]

LGTM.