docs: add more detail to Cloud Run deployer page by renzodavid9 · Pull Request #8381 · GoogleContainerTools/skaffold

renzodavid9 · 2023-01-30T17:13:30Z

Description
This PR adds more details for the Cloud Run deployer page.

http://35.226.237.45:1313/docs/pipeline-stages/deployers/cloudrun/

codecov · 2023-01-30T17:35:31Z

Codecov Report

Merging #8381 (8c85c75) into main (290280e) will decrease coverage by 4.60%.
The diff coverage is 54.85%.

@@            Coverage Diff             @@
##             main    #8381      +/-   ##
==========================================
- Coverage   70.48%   65.88%   -4.60%     
==========================================
  Files         515      605      +90     
  Lines       23150    29819    +6669     
==========================================
+ Hits        16317    19646    +3329     
- Misses       5776     8698    +2922     
- Partials     1057     1475     +418

Impacted Files	Coverage Δ
cmd/skaffold/app/cmd/completion.go	`13.04% <0.00%> (-1.25%)`	⬇️
cmd/skaffold/app/cmd/config/list.go	`65.21% <ø> (ø)`
cmd/skaffold/app/cmd/config/set.go	`88.72% <ø> (ø)`
cmd/skaffold/app/cmd/config/util.go	`54.28% <ø> (ø)`
cmd/skaffold/app/cmd/credits.go	`100.00% <ø> (ø)`
cmd/skaffold/app/cmd/credits/export.go	`0.00% <0.00%> (ø)`
cmd/skaffold/app/cmd/deploy.go	`40.90% <0.00%> (-12.94%)`	⬇️
cmd/skaffold/app/cmd/generate_pipeline.go	`60.00% <ø> (ø)`
cmd/skaffold/app/cmd/inspect_modules.go	`65.00% <ø> (ø)`
cmd/skaffold/app/cmd/inspect_profiles.go	`66.66% <ø> (ø)`
... and 415 more

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

container-tools-bot · 2023-01-31T17:12:10Z

Please visit http://34.28.55.185:1313 to view changes to the docs.

aaron-prindle · 2023-02-02T07:27:48Z

+apiVersion: serving.knative.dev/v1
+kind: Service
+metadata:
+  name: cloud-run-service-name


Suggested change

name: cloud-run-service-name

name: cloud-run-service-name # this service will be created in Cloud Deploy via Skaffold

Change applied with the following text: this service will be created in Cloud Run via Skaffold: Changed Cloud Deploy to Cloud Run. Also I added the same comment for the Job.

aaron-prindle · 2023-02-02T07:28:33Z

+apiVersion: run.googleapis.com/v1
+kind: Job
+metadata:
+  name: cloud-run-job-name


Might make sense to add a note/section explaining how Job is currently supported (can create Jobs but not trigger them)

Agree. I already had a note about it, but I just changed it to make it look with the Notes format (as the card from the beginning of the page), let me know what do you think 😄

aaron-prindle · 2023-02-02T07:29:21Z

Can you also change the maturity of Cloud Run to beta from alpha in this PR. This PR shows where this info is stored:
#8280

Co-authored-by: Aaron Prindle <aprindle@google.com>

container-tools-bot · 2023-02-02T15:53:35Z

Please visit http://35.226.237.45:1313 to view changes to the docs.

renzodavid9 · 2023-02-02T15:56:17Z

Can you also change the maturity of Cloud Run to beta from alpha in this PR. This PR shows where this info is stored:
#8280

Done! Maturity changed

aaron-prindle

LGTM!

docs: add more detail to Cloud Run deployer page

6bbe266

pull-request-size Bot added the size/L label Jan 30, 2023

renzodavid9 requested a review from aaron-prindle January 31, 2023 17:07

renzodavid9 marked this pull request as ready for review January 31, 2023 17:07

renzodavid9 requested a review from a team January 31, 2023 17:07

renzodavid9 added the docs-modifications-v2 runs the docs v2 preview service on the given PR label Jan 31, 2023

container-tools-bot removed the docs-modifications-v2 runs the docs v2 preview service on the given PR label Jan 31, 2023