Skip to content

feat: add k8s Job support to verify and status check#8415

Merged
aaron-prindle merged 2 commits into
GoogleContainerTools:mainfrom
aaron-prindle:fix-8139-v5
Mar 8, 2023
Merged

feat: add k8s Job support to verify and status check#8415
aaron-prindle merged 2 commits into
GoogleContainerTools:mainfrom
aaron-prindle:fix-8139-v5

Conversation

@aaron-prindle

@aaron-prindle aaron-prindle commented Feb 8, 2023 •
edited
Loading

Copy link
Copy Markdown
Contributor

fixes #8139

NOTE: now updated to meet backwards compatible schema vs updated schema
@aaron-prindle aaron-prindle force-pushed the fix-8139-v5 branch 7 times, most recently from 727a258 to 792529a Compare February 9, 2023 23:43
@aaron-prindle aaron-prindle requested a review from a team as a code owner February 9, 2023 23:43
@codecov

codecov Bot commented Feb 10, 2023 •
edited
Loading

Copy link
Copy Markdown

Codecov Report

Merging #8415 (00ebcb3) into main (290280e) will decrease coverage by 6.11%.
The diff coverage is 54.57%.

@@            Coverage Diff             @@
##             main    #8415      +/-   ##
==========================================
- Coverage   70.48%   64.37%   -6.11%     
==========================================
  Files         515      605      +90     
  Lines       23150    30266    +7116     
==========================================
+ Hits        16317    19484    +3167     
- Misses       5776     9311    +3535     
- Partials     1057     1471     +414
Impacted Files Coverage Δ
cmd/skaffold/app/cmd/completion.go 13.04% <0.00%> (-1.25%) ⬇️
cmd/skaffold/app/cmd/config/list.go 65.21% <ø> (ø)
cmd/skaffold/app/cmd/config/set.go 88.72% <ø> (ø)
cmd/skaffold/app/cmd/config/util.go 54.28% <ø> (ø)
cmd/skaffold/app/cmd/credits.go 100.00% <ø> (ø)
cmd/skaffold/app/cmd/credits/export.go 0.00% <0.00%> (ø)
cmd/skaffold/app/cmd/deploy.go 40.90% <0.00%> (-12.94%) ⬇️
cmd/skaffold/app/cmd/generate_pipeline.go 60.00% <ø> (ø)
cmd/skaffold/app/cmd/inspect_modules.go 65.00% <ø> (ø)
cmd/skaffold/app/cmd/inspect_profiles.go 66.66% <ø> (ø)
... and 429 more

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more
@aaron-prindle aaron-prindle force-pushed the fix-8139-v5 branch 5 times, most recently from fd3f6a1 to 27cd68d Compare February 14, 2023 18:05
@aaron-prindle aaron-prindle force-pushed the fix-8139-v5 branch 8 times, most recently from a1730f4 to 4145ddc Compare February 22, 2023 03:05
@aaron-prindle aaron-prindle force-pushed the fix-8139-v5 branch 2 times, most recently from f9b2d82 to 7b24b42 Compare February 22, 2023 03:25
@aaron-prindle aaron-prindle force-pushed the fix-8139-v5 branch 6 times, most recently from 3b7f406 to 6331bd6 Compare February 22, 2023 22:53
renzodavid9
renzodavid9 reviewed Feb 22, 2023
View reviewed changes
Comment thread pkg/skaffold/verify/k8sjob/verify.go
Comment thread pkg/skaffold/verify/k8sjob/verify.go Outdated
Comment thread pkg/skaffold/verify/k8sjob/verify.go Outdated
Comment thread pkg/skaffold/verify/k8sjob/verify.go Outdated
Comment thread pkg/skaffold/verify/k8sjob/verify.go Outdated
@aaron-prindle aaron-prindle force-pushed the fix-8139-v5 branch 7 times, most recently from a91ee6b to 9b056f7 Compare February 23, 2023 01:14
renzodavid9
renzodavid9 reviewed Feb 23, 2023
View reviewed changes
Comment thread pkg/skaffold/verify/verify_mux.go Outdated
Comment thread pkg/skaffold/verify/verify_mux.go Outdated
@aaron-prindle aaron-prindle merged commit 3677ec7 into GoogleContainerTools:main Mar 8, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment