Skip to content

docs: add tooltip with yaml path in Skaffold yaml reference page#8477

Merged
aaron-prindle merged 1 commit into
GoogleContainerTools:mainfrom
renzodavid9:yaml-tooltip
Mar 8, 2023
Merged

docs: add tooltip with yaml path in Skaffold yaml reference page#8477
aaron-prindle merged 1 commit into
GoogleContainerTools:mainfrom
renzodavid9:yaml-tooltip

Conversation

@renzodavid9

Copy link
Copy Markdown
Contributor

Description
This change adds a new on hover tooltip in the Skaffold yaml reference indicating the full structure where the key is located in the file:

image

Known issue
The tooltip for the first property in the yaml file, apiVersion, is not visible, we'll need to check better the CSS to remove the overflow-x: auto from the table without breaking the styles.

@renzodavid9 renzodavid9 added the docs-modifications-v2 runs the docs v2 preview service on the given PR label Feb 24, 2023
@container-tools-bot

Copy link
Copy Markdown

Please visit http://34.122.20.87:1313 to view changes to the docs.

@container-tools-bot container-tools-bot removed the docs-modifications-v2 runs the docs v2 preview service on the given PR label Feb 24, 2023
@codecov

codecov Bot commented Feb 24, 2023

Copy link
Copy Markdown

Codecov Report

Merging #8477 (f8e46ff) into main (290280e) will decrease coverage by 5.29%.
The diff coverage is 55.02%.

@@            Coverage Diff             @@
##             main    #8477      +/-   ##
==========================================
- Coverage   70.48%   65.19%   -5.29%     
==========================================
  Files         515      602      +87     
  Lines       23150    29884    +6734     
==========================================
+ Hits        16317    19484    +3167     
- Misses       5776     8926    +3150     
- Partials     1057     1474     +417     
Impacted Files Coverage Δ
cmd/skaffold/app/cmd/completion.go 13.04% <0.00%> (-1.25%) ⬇️
cmd/skaffold/app/cmd/config/list.go 65.21% <ø> (ø)
cmd/skaffold/app/cmd/config/set.go 88.72% <ø> (ø)
cmd/skaffold/app/cmd/config/util.go 54.28% <ø> (ø)
cmd/skaffold/app/cmd/credits.go 100.00% <ø> (ø)
cmd/skaffold/app/cmd/credits/export.go 0.00% <0.00%> (ø)
cmd/skaffold/app/cmd/deploy.go 40.90% <0.00%> (-12.94%) ⬇️
cmd/skaffold/app/cmd/generate_pipeline.go 60.00% <ø> (ø)
cmd/skaffold/app/cmd/inspect_modules.go 65.00% <ø> (ø)
cmd/skaffold/app/cmd/inspect_profiles.go 66.66% <ø> (ø)
... and 426 more

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@aaron-prindle aaron-prindle marked this pull request as ready for review March 8, 2023 21:25

@aaron-prindle aaron-prindle left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! Very cool!

@aaron-prindle aaron-prindle merged commit 2f44132 into GoogleContainerTools:main Mar 8, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

3 participants