Skip to content

fix: don't apply basepath when looking up image names for re-tagging multi-arch images#8485

Closed
dsiebel wants to merge 1 commit into
GoogleContainerTools:mainfrom
trivago:8380-retag-multi-arch-manifest
Closed

fix: don't apply basepath when looking up image names for re-tagging multi-arch images#8485
dsiebel wants to merge 1 commit into
GoogleContainerTools:mainfrom
trivago:8380-retag-multi-arch-manifest

Conversation

@dsiebel

@dsiebel dsiebel commented Mar 2, 2023

Copy link
Copy Markdown
Contributor

Fixes: #8380

Description

Addresses the issue described in #8380 where re-tagging multi-arch builds with e.g. a cache tag, re-tags the first manifest returned by the registry instead of re-tagging the multi-arch manifest.

Further details are described in this issue comment.

User facing changes (remove if N/A)

Before: running skaffold build --tag xy for an already existing multi-arch image would re-tag e.g. the *_amd64 image version instead of the multi-arch manifest (no suffix).
This results in errors when trying to pull the xy image tag on a non-matching arch, e.g. arm64.

After: running skaffold build --tag xy for an already existing multi-arch image adds a tag xy to the multi-arch manifest.

@conventional-commit-lint-gcf

conventional-commit-lint-gcf Bot commented Mar 2, 2023

Copy link
Copy Markdown

🤖 I detect that the PR title and the commit message differ and there's only one commit. To use the PR title for the commit history, you can use Github's automerge feature with squashing, or use automerge label. Good luck human!

-- conventional-commit-lint bot
https://conventionalcommits.org/

@gsquared94

Copy link
Copy Markdown
Contributor

thanks @dsiebel for opening this. I submitted #8493 with a fix that addresses all scenarios including this one for incorrect platform selected during retagging.

@gsquared94 gsquared94 closed this Mar 6, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

2 participants