fix: don't apply basepath when looking up image names for re-tagging multi-arch images#8485
Closed
dsiebel wants to merge 1 commit into
Closed
fix: don't apply basepath when looking up image names for re-tagging multi-arch images#8485dsiebel wants to merge 1 commit into
dsiebel wants to merge 1 commit into
Conversation
|
🤖 I detect that the PR title and the commit message differ and there's only one commit. To use the PR title for the commit history, you can use Github's automerge feature with squashing, or use -- conventional-commit-lint bot |
Contributor
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes: #8380
Description
Addresses the issue described in #8380 where re-tagging multi-arch builds with e.g. a
cachetag, re-tags the first manifest returned by the registry instead of re-tagging the multi-arch manifest.Further details are described in this issue comment.
User facing changes (remove if N/A)
Before: running
skaffold build --tag xyfor an already existing multi-arch image would re-tag e.g. the*_amd64image version instead of the multi-arch manifest (no suffix).This results in errors when trying to pull the
xyimage tag on a non-matching arch, e.g.arm64.After: running
skaffold build --tag xyfor an already existing multi-arch image adds a tagxyto the multi-arch manifest.