Skip to content

feat: Whitelist strimzi.io CRDs#8491

Merged
aaron-prindle merged 2 commits into
GoogleContainerTools:mainfrom
uniiverse:strimzi
Mar 8, 2023
Merged

feat: Whitelist strimzi.io CRDs#8491
aaron-prindle merged 2 commits into
GoogleContainerTools:mainfrom
uniiverse:strimzi

Conversation

@deedubs

@deedubs deedubs commented Mar 3, 2023

Copy link
Copy Markdown
Contributor

Allow replacing images in strimzi.io CRD files

Allow replacing images in strimzi.io CRD files
@codecov

codecov Bot commented Mar 3, 2023

Copy link
Copy Markdown

Codecov Report

Merging #8491 (53233c7) into main (290280e) will decrease coverage by 5.29%.
The diff coverage is 55.02%.

@@            Coverage Diff             @@
##             main    #8491      +/-   ##
==========================================
- Coverage   70.48%   65.19%   -5.29%     
==========================================
  Files         515      602      +87     
  Lines       23150    29912    +6762     
==========================================
+ Hits        16317    19501    +3184     
- Misses       5776     8939    +3163     
- Partials     1057     1472     +415     
Impacted Files Coverage Δ
cmd/skaffold/app/cmd/completion.go 13.04% <0.00%> (-1.25%) ⬇️
cmd/skaffold/app/cmd/config/list.go 65.21% <ø> (ø)
cmd/skaffold/app/cmd/config/set.go 88.72% <ø> (ø)
cmd/skaffold/app/cmd/config/util.go 54.28% <ø> (ø)
cmd/skaffold/app/cmd/credits.go 100.00% <ø> (ø)
cmd/skaffold/app/cmd/credits/export.go 0.00% <0.00%> (ø)
cmd/skaffold/app/cmd/deploy.go 40.90% <0.00%> (-12.94%) ⬇️
cmd/skaffold/app/cmd/generate_pipeline.go 60.00% <ø> (ø)
cmd/skaffold/app/cmd/inspect_modules.go 65.00% <ø> (ø)
cmd/skaffold/app/cmd/inspect_profiles.go 66.66% <ø> (ø)
... and 425 more

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@deedubs

deedubs commented Mar 3, 2023

Copy link
Copy Markdown
Contributor Author

Test failure looks like a timeout in an unrelated test

@aaron-prindle

Copy link
Copy Markdown
Contributor

Re-triggered the test, passing now\

@aaron-prindle aaron-prindle left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the PR here @deedubs. LGTM!

@aaron-prindle aaron-prindle merged commit fd6a654 into GoogleContainerTools:main Mar 8, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

2 participants