fix: correctly rewrite /deploy/kubectl/manifests in patch upgrades#8585
Merged
ericzzzzzzz merged 1 commit intoMar 25, 2023
Merged
Conversation
|
Thanks for your pull request! It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA). View this failed invocation of the CLA check for more information. For the most up to date status, view the checks section at the bottom of the pull request. |
Codecov Report
@@ Coverage Diff @@
## main #8585 +/- ##
==========================================
- Coverage 70.48% 64.24% -6.24%
==========================================
Files 515 610 +95
Lines 23150 30579 +7429
==========================================
+ Hits 16317 19646 +3329
- Misses 5776 9461 +3685
- Partials 1057 1472 +415
... and 388 files with indirect coverage changes 📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
ericzzzzzzz
approved these changes
Mar 25, 2023
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes: #8564
Description
This looks like a fairly simple fix to me. #7800 added functionality to rewrite yaml paths in patches during v2->v3 upgrades. Only
/deploy/kubectl/manifestsshould be rewritten to/manifests/rawYamlthough, not all of/deploy/kubectl.