Skip to content

chore: "revert upgrade docker version in skaffold image (#8583)"#8590

Merged
aaron-prindle merged 1 commit into
GoogleContainerTools:mainfrom
ericzzzzzzz:revert-docker-upgrade
Mar 27, 2023
Merged

chore: "revert upgrade docker version in skaffold image (#8583)"#8590
aaron-prindle merged 1 commit into
GoogleContainerTools:mainfrom
ericzzzzzzz:revert-docker-upgrade

Conversation

@ericzzzzzzz

Copy link
Copy Markdown
Contributor

This reverts commit 1f1fa70.

Fixes: #nnn
Related: Relevant tracking issues, for context
Merge before/after: Dependent or prerequisite PRs

Description

User facing changes (remove if N/A)

Follow-up Work (remove if N/A)

@codecov

codecov Bot commented Mar 27, 2023

Copy link
Copy Markdown

Codecov Report

Merging #8590 (2d1471a) into main (290280e) will decrease coverage by 6.29%.
The diff coverage is 54.32%.

@@            Coverage Diff             @@
##             main    #8590      +/-   ##
==========================================
- Coverage   70.48%   64.20%   -6.29%     
==========================================
  Files         515      610      +95     
  Lines       23150    30595    +7445     
==========================================
+ Hits        16317    19642    +3325     
- Misses       5776     9480    +3704     
- Partials     1057     1473     +416     
Impacted Files Coverage Δ
cmd/skaffold/app/cmd/completion.go 13.04% <0.00%> (-1.25%) ⬇️
cmd/skaffold/app/cmd/config/list.go 65.21% <ø> (ø)
cmd/skaffold/app/cmd/config/set.go 88.72% <ø> (ø)
cmd/skaffold/app/cmd/config/util.go 54.28% <ø> (ø)
cmd/skaffold/app/cmd/credits.go 100.00% <ø> (ø)
cmd/skaffold/app/cmd/credits/export.go 0.00% <0.00%> (ø)
cmd/skaffold/app/cmd/deploy.go 40.90% <0.00%> (-12.94%) ⬇️
cmd/skaffold/app/cmd/generate_pipeline.go 60.00% <ø> (ø)
cmd/skaffold/app/cmd/inspect_modules.go 65.00% <ø> (ø)
cmd/skaffold/app/cmd/inspect_profiles.go 66.66% <ø> (ø)
... and 38 more

... and 389 files with indirect coverage changes

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@aaron-prindle aaron-prindle left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@aaron-prindle aaron-prindle merged commit a1b61e2 into GoogleContainerTools:main Mar 27, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

2 participants