feat: new k8s task and exec env for custom actions#8755
Merged
aaron-prindle merged 9 commits intoMay 16, 2023
Conversation
renzodavid9
force-pushed
the
ca-feature-8521
branch
from
8c0f0e9 to
6a9a861
Compare
Codecov Report
@@ Coverage Diff @@
## main #8755 +/- ##
==========================================
- Coverage 70.48% 63.94% -6.55%
==========================================
Files 515 620 +105
Lines 23150 31455 +8305
==========================================
+ Hits 16317 20113 +3796
- Misses 5776 9837 +4061
- Partials 1057 1505 +448
... and 410 files with indirect coverage changes 📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
renzodavid9
force-pushed
the
ca-feature-8521
branch
4 times, most recently
from
38b4f5b to
11770e6
Compare
renzodavid9
commented
May 10, 2023
| err = a.Exec(ctx, out) | ||
| log.Entry(ctx).Debugf("Finished execution for %v", a.name) | ||
| r.cleanup(ctx, out, []Task{a}, []ExecEnv{execEnv}) | ||
| r.cleanup(context.TODO(), out, []Task{a}, []ExecEnv{execEnv}) |
Contributor
Author
There was a problem hiding this comment.
When the ctx is cancelled due to an event not related with the actions runner, e.g, a CTRL+C event, the cleanup will fail due to the canceled context that is using, so, we need to send a context.TODO() to avoid this case.
renzodavid9
force-pushed
the
ca-feature-8521
branch
from
11770e6 to
82f221a
Compare
renzodavid9
force-pushed
the
ca-feature-8521
branch
3 times, most recently
from
7713c9f to
02cc8cc
Compare
renzodavid9
force-pushed
the
ca-feature-8521
branch
from
02cc8cc to
2ce3cff
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes: #8521 #8560
Description
This PR adds the logic to execute k8s custom actions as jobs inside the cluster.