Skip to content

test: disable failing buildpacks tests#8812

Merged
renzodavid9 merged 1 commit into
GoogleContainerTools:mainfrom
renzodavid9:buildpacks-tests
May 24, 2023
Merged

test: disable failing buildpacks tests#8812
renzodavid9 merged 1 commit into
GoogleContainerTools:mainfrom
renzodavid9:buildpacks-tests

Conversation

@renzodavid9

Copy link
Copy Markdown
Contributor

Related: #8811

Description
This PR disable the buildpacks tests that are failing. These tests started to fail without any changes in the Skaffold logic related with buildpacks.

@aaron-prindle aaron-prindle marked this pull request as ready for review May 23, 2023 22:22
@aaron-prindle aaron-prindle requested a review from a team as a code owner May 23, 2023 22:22
@aaron-prindle aaron-prindle requested a review from ericzzzzzzz May 23, 2023 22:22

@aaron-prindle aaron-prindle left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@codecov

codecov Bot commented May 23, 2023

Copy link
Copy Markdown

Codecov Report

Merging #8812 (527b37a) into main (290280e) will decrease coverage by 6.55%.
The diff coverage is 50.00%.

@@            Coverage Diff             @@
##             main    #8812      +/-   ##
==========================================
- Coverage   70.48%   63.94%   -6.55%     
==========================================
  Files         515      620     +105     
  Lines       23150    31455    +8305     
==========================================
+ Hits        16317    20113    +3796     
- Misses       5776     9837    +4061     
- Partials     1057     1505     +448     
Impacted Files Coverage Δ
cmd/skaffold/app/cmd/completion.go 13.04% <0.00%> (-1.25%) ⬇️
cmd/skaffold/app/cmd/config/list.go 65.21% <ø> (ø)
cmd/skaffold/app/cmd/config/set.go 88.72% <ø> (ø)
cmd/skaffold/app/cmd/config/util.go 54.28% <ø> (ø)
cmd/skaffold/app/cmd/credits.go 100.00% <ø> (ø)
cmd/skaffold/app/cmd/credits/export.go 0.00% <0.00%> (ø)
cmd/skaffold/app/cmd/deploy.go 40.90% <0.00%> (-12.94%) ⬇️
cmd/skaffold/app/cmd/generate_pipeline.go 60.00% <ø> (ø)
cmd/skaffold/app/cmd/inspect_modules.go 65.00% <ø> (ø)
cmd/skaffold/app/cmd/inspect_profiles.go 66.66% <ø> (ø)
... and 40 more

... and 410 files with indirect coverage changes

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@renzodavid9 renzodavid9 merged commit 75c4495 into GoogleContainerTools:main May 24, 2023
plumpy pushed a commit to plumpy/skaffold that referenced this pull request May 24, 2023
aaron-prindle pushed a commit that referenced this pull request May 24, 2023
(cherry picked from commit 75c4495)

Co-authored-by: Renzo Rojas <renzor@google.com>
plumpy pushed a commit to plumpy/skaffold that referenced this pull request May 25, 2023
plumpy pushed a commit to plumpy/skaffold that referenced this pull request May 25, 2023
renzodavid9 added a commit that referenced this pull request May 25, 2023
(cherry picked from commit 75c4495)

Co-authored-by: Renzo Rojas <renzor@google.com>
renzodavid9 added a commit that referenced this pull request May 25, 2023
(cherry picked from commit 75c4495)

Co-authored-by: Renzo Rojas <renzor@google.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

2 participants