Skip to content

docs: fix reference to dateTime tagger#8813

Merged
aaron-prindle merged 1 commit into
GoogleContainerTools:mainfrom
bnjmn:patch-1
May 24, 2023
Merged

docs: fix reference to dateTime tagger#8813
aaron-prindle merged 1 commit into
GoogleContainerTools:mainfrom
bnjmn:patch-1

Conversation

@bnjmn

@bnjmn bnjmn commented May 23, 2023

Copy link
Copy Markdown
Contributor

Fix reference to dateTime tagger that errors out if followed exactly.

Description
While following the docs I tried using the datetime tagger as it is written and got an error. Tried editing it to dateTime and it worked. Thought I'd suggest this change to hopefully help others that may run into an issue with it in the future. Thanks!

@google-cla

google-cla Bot commented May 23, 2023

Copy link
Copy Markdown

Thanks for your pull request! It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

View this failed invocation of the CLA check for more information.

For the most up to date status, view the checks section at the bottom of the pull request.

@bnjmn bnjmn changed the title Update taggers.md May 23, 2023
@codecov

codecov Bot commented May 24, 2023

Copy link
Copy Markdown

Codecov Report

Merging #8813 (b9738d5) into main (290280e) will decrease coverage by 6.54%.
The diff coverage is 50.00%.

@@            Coverage Diff             @@
##             main    #8813      +/-   ##
==========================================
- Coverage   70.48%   63.94%   -6.54%     
==========================================
  Files         515      620     +105     
  Lines       23150    31455    +8305     
==========================================
+ Hits        16317    20114    +3797     
- Misses       5776     9835    +4059     
- Partials     1057     1506     +449     
Impacted Files Coverage Δ
cmd/skaffold/app/cmd/completion.go 13.04% <0.00%> (-1.25%) ⬇️
cmd/skaffold/app/cmd/config/list.go 65.21% <ø> (ø)
cmd/skaffold/app/cmd/config/set.go 88.72% <ø> (ø)
cmd/skaffold/app/cmd/config/util.go 54.28% <ø> (ø)
cmd/skaffold/app/cmd/credits.go 100.00% <ø> (ø)
cmd/skaffold/app/cmd/credits/export.go 0.00% <0.00%> (ø)
cmd/skaffold/app/cmd/deploy.go 40.90% <0.00%> (-12.94%) ⬇️
cmd/skaffold/app/cmd/generate_pipeline.go 60.00% <ø> (ø)
cmd/skaffold/app/cmd/inspect_modules.go 65.00% <ø> (ø)
cmd/skaffold/app/cmd/inspect_profiles.go 66.66% <ø> (ø)
... and 40 more

... and 409 files with indirect coverage changes

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@aaron-prindle aaron-prindle left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @bnjmn! LGTM

@aaron-prindle aaron-prindle merged commit e5a0471 into GoogleContainerTools:main May 24, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

2 participants